-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(engine): specify an error message when deployed process id not found in state #12196
refactor(engine): specify an error message when deployed process id not found in state #12196
Conversation
…ot found in state There is an issue that when a deployed process cannot be found in state, NoSuchElementException is thrown. Currently, we could not re-produce the issue. This PR adds an error message that contains persisted processes id so that we can use this id to inspect process through 'zdb' and retrieve the resource XML from there. Then, we can use that XML to reproduce the issue locally and debug it to find the actual problem.
Test Results1 044 files ± 0 1 044 suites ±0 1h 51m 51s ⏱️ +19s Results for commit a816590. ± Comparison against base commit b0cf727. This pull request removes 473 and adds 688 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @berkaycanbc 🥇
LGTM 👍
PS: 🔧 Please add a comment to the issue that is being closed by this pull request, stating that we should re-open it when we encounter a log message:
Expected to find executable process in persisted process with key '%s', but after transformation no such executable process could be found
bors merge |
Build succeeded: |
Successfully created backport PR for |
Successfully created backport PR for |
12220: [Backport stable/8.1] refactor(engine): specify an error message when deployed process id not found in state r=oleschoenburg a=backport-action # Description Backport of #12196 to `stable/8.1`. relates to #11414 12429: [Backport stable/8.1] test(qa): save logs of zeebe containers if the test fails r=oleschoenburg a=backport-action # Description Backport of #12428 to `stable/8.1`. relates to #12396 12468: [Backport 8.1]: skip unnecessary blacklist check r=oleschoenburg a=Zelldon ## Description Backport #12306 <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes to #12041 Co-authored-by: berkaycanbc <berkay.can@camunda.com> Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
Description
There is an issue that when a deployed process cannot be found in state,
NoSuchElementException
is thrown. Currently, we could not re-produce the issue. This PR adds an error message that contains persisted processes id so that we can use this id to inspect process through zdb and retrieve the resource XML from there. Then, we can use that XML to reproduce the issue locally and debug it to find the actual problem.Related issues
closes #11414
Note: It closes the issue above but a new issue will be opened again when we identify the exact cause.
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.