deps(maven): bump reactive-streams from 1.0.3 to 1.0.4 #12263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Test Results1 047 files ± 0 1 047 suites ±0 2h 13m 51s ⏱️ + 10m 21s Results for commit 064ee3a. ± Comparison against base commit e760069. This pull request removes 569 and adds 695 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
@dependabot rebase |
|
Looks like this PR is already up-to-date with stable/8.2! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/maven/stable/8.2/org.reactivestreams-reactive-streams-1.0.4
branch
from
5532049 to
0bbf011
Compare
|
Dependency convergence woohoo! |
npepinpe
force-pushed
the
dependabot/maven/stable/8.2/org.reactivestreams-reactive-streams-1.0.4
branch
from
0bbf011 to
f6de88a
Compare
|
Uh, maybe this test is really faulty with the update to 1.0.4. Though I don't see how Netty stuff would be affected by this 🤔 |
|
Not reproducible locally 🤔 |
|
I think the fact we're overriding the channel pool factory to spy on channels is messing things up. Unfortunately we modify the state of the messaging service during channel bootstrap, and so weird things happen if we return a spied channel (which is effectively a different instance of a channel), such as creating two different remote connections, which messes up the communication. I can't guarantee this is the problem, but it might be related. |
Bumps [reactive-streams](https://github.com/reactive-streams/reactive-streams) from 1.0.3 to 1.0.4. - [Release notes](https://github.com/reactive-streams/reactive-streams/releases) - [Changelog](https://github.com/reactive-streams/reactive-streams-jvm/blob/master/RELEASE-NOTES.md) - [Commits](reactive-streams/reactive-streams-jvm@v1.0.3...v1.0.4) --- updated-dependencies: - dependency-name: org.reactivestreams:reactive-streams dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
npepinpe
force-pushed
the
dependabot/maven/stable/8.2/org.reactivestreams-reactive-streams-1.0.4
branch
2 times, most recently
from
2ca43c3 to
064ee3a
Compare
14 tasks
|
Build succeeded: |
ghost
deleted the
dependabot/maven/stable/8.2/org.reactivestreams-reactive-streams-1.0.4
branch
ghost
pushed a commit
that referenced
this pull request
Apr 13, 2023
12397: Remove spy/mock usage from NettyMessagingService channel pool related tests r=npepinpe a=npepinpe ## Description This PR attempts to simplify the tests by removing the usage of mocks. This could cause issues since the channel bootstrapping itself from the `NettyMessagingService` will modify the service state, and uses channels as identity keys in some maps. Spying and returning the spied channel will cause invalid look ups, and simply complicated things. It also ensures we close the messaging service we were starting in those tests, something we were not previously doing. ## Related issues related to #12263 where the race condition was happening often (although this is now fixed thanks to Deepthi 🎉) Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
ghost
pushed a commit
that referenced
this pull request
Apr 14, 2023
ghost
pushed a commit
that referenced
this pull request
Apr 14, 2023
12408: [Backport stable/8.0] Remove spy/mock usage from NettyMessagingService channel pool related tests r=deepthidevaki a=npepinpe # Description Backport of #12397 to `stable/8.0`. relates to #12263 12409: deps(maven): bump spring-framework-bom from 5.3.26 to 5.3.27 r=github-actions[bot] a=dependabot[bot] Bumps [spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.26 to 5.3.27. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spring-projects/spring-framework/releases">spring-framework-bom's releases</a>.</em></p> <blockquote> <h2>v5.3.27</h2> <h2>:star: New Features</h2> <ul> <li>Limit string concatenation in SpEL expressions <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30331">#30331</a></li> <li>Limit SpEL expression length <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30329">#30329</a></li> <li>Disable variable assignment in SimpleEvaluationContext <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30327">#30327</a></li> <li>Introduce <code>StringUtils.truncate()</code> <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30291">#30291</a></li> <li>Introduce <code>ObjectUtils.nullSafeConciseToString()</code> <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30287">#30287</a></li> <li>Make <code>HttpComponentsHeadersAdapter#getFirst</code> nullable <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30269">#30269</a></li> </ul> <h2>:lady_beetle: Bug Fixes</h2> <ul> <li>Fix regression in ReactorServerHttpRequest related to IPV6 Zone id with "%" <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30314">#30314</a></li> <li>SSE breaks with indenting serializer in WebMvc.fn <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30302">#30302</a></li> <li>Increase max regex length in SpEL expressions <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30298">#30298</a></li> <li>NullPointerException on timeout in HttpComponentsClientHttpConnector when using Apache HttpComponents <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30246">#30246</a></li> <li>Wrong MockRestRequestMatchers.header() method in spring-test being invoked (JDK issue?) <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30235">#30235</a></li> <li>TypeNotPresentException: org/springframework/cglib/proxy/NoOp not present on Java 17 <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30228">#30228</a></li> <li>Refine generic type management in <code>AbstractMessageWriterResultHandler</code> <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30215">#30215</a></li> <li>MvcUriComponentsBuilder.fromMethodCall breaks for controller with CharSequence return type <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30212">#30212</a></li> <li>Handle all exceptions for stored proc output param retrieval in <code>SharedEntityManagerCreator</code> <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30164">#30164</a></li> </ul> <h2>:notebook_with_decorative_cover: Documentation</h2> <ul> <li>Fix <code>`@PathVariable</code>` reference documentation code snippets <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30258">#30258</a></li> <li>Fix example in Javadoc for <code>`@EnableWebSocket</code>` <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30187">#30187</a></li> <li>Fix anchor in link to "Web on Reactive Stack" chapter <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30163">#30163</a></li> </ul> <h2>:hammer: Dependency Upgrades</h2> <ul> <li>Upgrade to Reactor 2020.0.31 <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30315">#30315</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/spring-projects/spring-framework/commit/08bc1a050ec87cdaad6b05170c27e34d3f90cafa"><code>08bc1a0</code></a> Release v5.3.27</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/6bfb94a563800313745ddc2c8eca0de6e17f2cb5"><code>6bfb94a</code></a> Disable variable assignment in SimpleEvaluationContext</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/ebc82654282bda547fbc20a9749ab1bda886a46f"><code>ebc8265</code></a> Limit SpEL expression length</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/86457464d767284a7c588292a39d6accf1f65bfe"><code>8645746</code></a> Limit string concatenation in SpEL expressions</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/be129dc17160c82da9e56b88321da13199cda2af"><code>be129dc</code></a> Change max regex length in SpEL expressions to 1000</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/8bb1b3eb443ec8c0e497cc1bf4f232d61097adaa"><code>8bb1b3e</code></a> Upgrade to Netty 4.1.91 and Checkstyle 10.9.3</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/6abd822e77722e6c92853f9abd470fb36e68a1e7"><code>6abd822</code></a> Upgrade to Reactor 2020.0.31</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/1c43a4c7ab46e7e5ac871b0fb1c04830c6299bc4"><code>1c43a4c</code></a> Fix regression in ReactorServerHttpRequest</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/423f2215c2c542426afa6682b8240e668bb133ed"><code>423f221</code></a> Remove flaky assertion to fix build on JDK 17</li> <li><a href="https://github.com/spring-projects/spring-framework/commit/0bad69d5fbab74cd1afded96fbf5ed287ece7f18"><code>0bad69d</code></a> Fix SSE with indenting serializer in WebMvc.fn</li> <li>Additional commits viewable in <a href="https://github.com/spring-projects/spring-framework/compare/v5.3.26...v5.3.27">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ghost
pushed a commit
that referenced
this pull request
Apr 14, 2023
megglos
added
the
version:8.2.2
lenaschoenburg
added
the
version:8.1.11
remcowesterhoud
added
version:8.3.0-alpha1
megglos
added
the
version:8.3.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps reactive-streams from 1.0.3 to 1.0.4.
Changelog
Sourced from reactive-streams's changelog.
... (truncated)
Commits
944163aPreparing for releasing 1.0.4899f17fMerge pull request #532 from akarnokd/patch-31f0cc2bDo not build on JDK 13.1744f5eMerge pull request #516 from sullis/github-actions-cia73647fUpdate .github/workflows/ci.yml45b8627migrate from Travis CI to GitHub Actions CIcb0710eAddresses #528 by upgrading testng to 7.3.0006202ePreparing relicensing to MIT-0d4d08aaCorrecting the wrong default timeout parameter in TestEnvironment ctor69098e1Merge pull request #524 from kiiadi/license-approvalDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)