Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 #12300

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

lenaschoenburg
Copy link
Member

Backport of #12251 to get rid of the AWS SDK v1

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Test Results

   870 files   -   80     870 suites   - 80   45m 37s ⏱️ - 57m 19s
7 089 tests  - 440  7 048 ✔️  - 472  5 💤  - 4  0 ±0  36 🔥 +36 
7 286 runs   - 440  7 243 ✔️  - 474  7 💤  - 2  0 ±0  36 🔥 +36 

For more details on these errors, see this check.

Results for commit e04116b. ± Comparison against base commit ffd7078.

This pull request removes 1059 and adds 619 tests. Note that renamed tests count towards both.
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=BUSINESS_RULE_TASK, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@612d1ca, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=CALL_ACTIVITY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@43ec59d9, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=END_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@3eabe216, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EVENT_BASED_GATEWAY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@6a8cbe29, variables={correlationKey=value}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EVENT_SUB_PROCESS, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@68f37931, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EXCLUSIVE_GATEWAY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@7a6cdb08, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=INTERMEDIATE_CATCH_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@43c5470d, variables={correlationKey=value}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=INTERMEDIATE_THROW_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@3a9b2ed7, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=MANUAL_TASK, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@26a26be9, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=MULTI_INSTANCE_BODY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@5fc47db2, variables={}]]
…
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=BUSINESS_RULE_TASK, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@96448ee, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=CALL_ACTIVITY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@345af277, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=END_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@3dd27116, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EVENT_BASED_GATEWAY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@4e53c6ef, variables={correlationKey=value}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EVENT_SUB_PROCESS, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@95aeee4, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EXCLUSIVE_GATEWAY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@3f1d4ecf, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=INTERMEDIATE_CATCH_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@3c1d6ef0, variables={correlationKey=value}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=INTERMEDIATE_THROW_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@2e2c9e24, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=MANUAL_TASK, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@507fecf3, variables={}]]
CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=MULTI_INSTANCE_BODY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@6164b3a2, variables={}]]
…

♻️ This comment has been updated with latest results.

@npepinpe
Copy link
Member

npepinpe commented Apr 6, 2023

Seems like network issues again 🤔

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lenaschoenburg
Copy link
Member Author

bors r+

ghost pushed a commit that referenced this pull request Apr 6, 2023
12280: [Backport stable/8.1] Omit RocksDB musl check from Docker image r=npepinpe a=backport-action

# Description
Backport of #12256 to `stable/8.1`.

relates to 

12286: Release 8.1.10 r=npepinpe a=camundait

Merge the release branch with stable. This pull request was created by Zeebe 🚀.

12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
Co-authored-by: github-actions[release]@users.noreply.github.com <github-actions[release]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Apr 6, 2023

Build failed (retrying...):

ghost pushed a commit that referenced this pull request Apr 6, 2023
12286: Release 8.1.10 r=npepinpe a=camundait

Merge the release branch with stable. This pull request was created by Zeebe 🚀.

12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

Co-authored-by: github-actions[release]@users.noreply.github.com <github-actions[release]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Apr 6, 2023

Build failed (retrying...):

ghost pushed a commit that referenced this pull request Apr 6, 2023
12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

12313: [Backport stable/8.1] Cut TCC provisioning by half r=npepinpe a=backport-action

# Description
Backport of #12304 to `stable/8.1`.

relates to 

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@ghost
Copy link

ghost commented Apr 6, 2023

Build failed (retrying...):

ghost pushed a commit that referenced this pull request Apr 6, 2023
12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Apr 6, 2023

Build failed:

@lenaschoenburg
Copy link
Member Author

bors r+

ghost pushed a commit that referenced this pull request Apr 6, 2023
12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Apr 6, 2023

Build failed:

@lenaschoenburg lenaschoenburg force-pushed the backport-12251-to-stable/8.1 branch from b4863c8 to 123a9e9 Compare April 11, 2023 07:23
@lenaschoenburg lenaschoenburg marked this pull request as draft April 11, 2023 10:00
@lenaschoenburg lenaschoenburg force-pushed the backport-12251-to-stable/8.1 branch 3 times, most recently from 661f52f to e04116b Compare April 11, 2023 10:11
dependabot bot and others added 2 commits April 18, 2023 10:51
Bumps [testcontainers-bom](https://github.com/testcontainers/testcontainers-java) from 1.17.6 to 1.18.0.
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.17.6...1.18.0)

---
updated-dependencies:
- dependency-name: org.testcontainers:testcontainers-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit e9a9028)
@lenaschoenburg lenaschoenburg force-pushed the backport-12251-to-stable/8.1 branch from e04116b to b39ce63 Compare April 18, 2023 08:51
@lenaschoenburg lenaschoenburg marked this pull request as ready for review April 18, 2023 10:06
@lenaschoenburg
Copy link
Member Author

bors r+

ghost pushed a commit that referenced this pull request Apr 18, 2023
12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Apr 18, 2023

Build failed:

@lenaschoenburg
Copy link
Member Author

bors retry

ghost pushed a commit that referenced this pull request Apr 18, 2023
12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Apr 18, 2023

Build failed:

@lenaschoenburg
Copy link
Member Author

bors merge

ghost pushed a commit that referenced this pull request Apr 19, 2023
12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Apr 19, 2023

Build failed:

@npepinpe
Copy link
Member

I don't think the issue is the concurrency. I noticed on stable/8.1 we have errors with the private registry, but haven't had time to look into it. That said, it could be the error is a red herring.

 {"message":"error with private registry proxying: unable to retag temporary image","code":500}

The private registry is a pull through cache, so you shouldn't be able to modify images directly on it, hence the error. But I don't really get why this would be happening, and why only on 8.1. Another PR for that branch had the same problem 🤔

@lenaschoenburg
Copy link
Member Author

lenaschoenburg commented Apr 20, 2023

The first time this PR passes CI is when I increase concurrency to 4 though 🤔
And I think this instability started around the time we lowered it to 2.

Do you want to look into this together? I'm not sure where to start here.

@npepinpe
Copy link
Member

Sure. If it temporarily fixes it, we can increase it again, and delegate the issue to them. It's also weird how it affects only one branch. What exactly is trying to retag an image here?

It could also be an issue on their side? For all I know, they might have their own pull through cache on their side, or they might be trying to do stuff with the private registry 🤷

@npepinpe
Copy link
Member

In the other PR where this was failing, normal CI was passing, but merging was not 🤷

@lenaschoenburg lenaschoenburg force-pushed the backport-12251-to-stable/8.1 branch from 2804af8 to 45e1261 Compare April 20, 2023 14:17
@lenaschoenburg lenaschoenburg force-pushed the backport-12251-to-stable/8.1 branch from 45e1261 to 2782b24 Compare April 20, 2023 14:18
@lenaschoenburg
Copy link
Member Author

bors r+

ghost pushed a commit that referenced this pull request Apr 20, 2023
12300: [Backport stable/8.1] deps(maven): bump testcontainers-bom from 1.17.6 to 1.18.0 r=oleschoenburg a=oleschoenburg

Backport of #12251 to get rid of the AWS SDK v1

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Apr 20, 2023

Build failed:

@lenaschoenburg
Copy link
Member Author

bors r+

@lenaschoenburg lenaschoenburg merged commit 3bbc95d into stable/8.1 Apr 20, 2023
@lenaschoenburg lenaschoenburg deleted the backport-12251-to-stable/8.1 branch April 20, 2023 15:02
@lenaschoenburg lenaschoenburg added the version:8.1.11 Marks an issue as being completely or in parts released in 8.1.11 label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.11 Marks an issue as being completely or in parts released in 8.1.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants