Use Github Actions for unit and integration tests #8968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
reviewed
Mar 23, 2022
lenaschoenburg
force-pushed
the
gha-unit-tests
branch
3 times, most recently
from
fc32d4c to
7bd2953
Compare
|
I can't quite get the unit tests to work, no matter how I choose to run them. It's always |
lenaschoenburg
force-pushed
the
gha-unit-tests
branch
6 times, most recently
from
620e7a5 to
46f7146
Compare
lenaschoenburg
force-pushed
the
gha-unit-tests
branch
from
afbc0d3 to
2f5518e
Compare
remcowesterhoud
requested changes
Mar 31, 2022
There was a problem hiding this comment.
Nice work @oleschoenburg! 🚀 Can't wait to have everything on GHA 😄
I have placed some questions and suggestions.
🔧 You mentioned during the team meeting that all only needed to archive the test results, since any tool would not give the full output anyways. I don't fully agree with this sentiment. I'm sure you've looked at the publish unit test result action. As you said it unfortunately does not provide all the logging. It does however, provide a quick overview which tests were the ones that are failing. This would at least give some pointers on where to look in the test reports.
For an example what it'd look like you could refer to: https://github.com/camunda/zeebe-process-test/runs/5770932644
Bonus: it could also add a comment with the results on your PR: camunda/zeebe-process-test#281
❌ You CodeQL seems to be failing. I don't see any change you made that would've caused this. Please take a look at it and judge if it's something you should fix.
windows-latest now points to windows-2022 Co-authored-by: Remco <remco@westerhoud.nl>
That's one that I actually haven't tried yet. I can try to add it here, let's see if this one manages to not run OOM 😄. I just noticed that it also supports matrix builds, which is awesome! https://github.com/EnricoMi/publish-unit-test-result-action#use-with-matrix-strategy
Yeah, not sure what's up with that. I think I've seen it once or twice before, I'd just ignore it for now and assume that it's fixed after merging. |
lenaschoenburg
force-pushed
the
gha-unit-tests
branch
from
464432b to
aaa72a4
Compare
|
It does support matrix, it is a little bit weird how it does it though. I've added it to ZPT so if you need help here let me know! |
lenaschoenburg
force-pushed
the
gha-unit-tests
branch
from
0298ca1 to
ebe8584
Compare
|
Thanks for the review so far @remcowesterhoud 🙇 |
remcowesterhoud
approved these changes
Mar 31, 2022
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 31, 2022
8968: Use Github Actions for unit and integration tests r=oleschoenburg a=oleschoenburg This is a refactoring and enhancement of our existing GitHub Actions workflows. With the changes here, we will have two workflows: * Tests * Code Quality They are not yet integrated with bors, meaning that they don't block merging if they fail and Jenkins is still the source of truth. ## Tests Includes the **OS support smoke tests**, **integration tests**, and **unit tests**. Tests are trigger for all pull requests and the `staging` and `trying` branches to support integration with bors in the future. Integration tests are run on a self-hosted runner. The elasticsearch exporter tests are run separately without flaky test detection on a smaller self-hosted runner. Most unit tests run in parallel on GitHub's hosted runners, except for the engine and logstream tests which are a bit too heavy and are run on a small self-hosted runner. ## Code Quality Includes **go-lint**, **CodeQL** and **java-formatting**. This PR makes no substantial changes to the go-lint and CodeQL jobs but adds another job to ensure that java code is properly formatted. In the future we could even add additional steps to the java formatting job to automatically suggest formatting changes in PRs. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Mar 31, 2022
8968: Use Github Actions for unit and integration tests r=oleschoenburg a=oleschoenburg This is a refactoring and enhancement of our existing GitHub Actions workflows. With the changes here, we will have two workflows: * Tests * Code Quality They are not yet integrated with bors, meaning that they don't block merging if they fail and Jenkins is still the source of truth. ## Tests Includes the **OS support smoke tests**, **integration tests**, and **unit tests**. Tests are trigger for all pull requests and the `staging` and `trying` branches to support integration with bors in the future. Integration tests are run on a self-hosted runner. The elasticsearch exporter tests are run separately without flaky test detection on a smaller self-hosted runner. Most unit tests run in parallel on GitHub's hosted runners, except for the engine and logstream tests which are a bit too heavy and are run on a small self-hosted runner. ## Code Quality Includes **go-lint**, **CodeQL** and **java-formatting**. This PR makes no substantial changes to the go-lint and CodeQL jobs but adds another job to ensure that java code is properly formatted. In the future we could even add additional steps to the java formatting job to automatically suggest formatting changes in PRs. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Mar 31, 2022
8968: Use Github Actions for unit and integration tests r=oleschoenburg a=oleschoenburg This is a refactoring and enhancement of our existing GitHub Actions workflows. With the changes here, we will have two workflows: * Tests * Code Quality They are not yet integrated with bors, meaning that they don't block merging if they fail and Jenkins is still the source of truth. ## Tests Includes the **OS support smoke tests**, **integration tests**, and **unit tests**. Tests are trigger for all pull requests and the `staging` and `trying` branches to support integration with bors in the future. Integration tests are run on a self-hosted runner. The elasticsearch exporter tests are run separately without flaky test detection on a smaller self-hosted runner. Most unit tests run in parallel on GitHub's hosted runners, except for the engine and logstream tests which are a bit too heavy and are run on a small self-hosted runner. ## Code Quality Includes **go-lint**, **CodeQL** and **java-formatting**. This PR makes no substantial changes to the go-lint and CodeQL jobs but adds another job to ensure that java code is properly formatted. In the future we could even add additional steps to the java formatting job to automatically suggest formatting changes in PRs. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
Oh the irony 🤣 bors retry |
ghost
pushed a commit
that referenced
this pull request
Mar 31, 2022
8968: Use Github Actions for unit and integration tests r=oleschoenburg a=oleschoenburg This is a refactoring and enhancement of our existing GitHub Actions workflows. With the changes here, we will have two workflows: * Tests * Code Quality They are not yet integrated with bors, meaning that they don't block merging if they fail and Jenkins is still the source of truth. ## Tests Includes the **OS support smoke tests**, **integration tests**, and **unit tests**. Tests are trigger for all pull requests and the `staging` and `trying` branches to support integration with bors in the future. Integration tests are run on a self-hosted runner. The elasticsearch exporter tests are run separately without flaky test detection on a smaller self-hosted runner. Most unit tests run in parallel on GitHub's hosted runners, except for the engine and logstream tests which are a bit too heavy and are run on a small self-hosted runner. ## Code Quality Includes **go-lint**, **CodeQL** and **java-formatting**. This PR makes no substantial changes to the go-lint and CodeQL jobs but adds another job to ensure that java code is properly formatted. In the future we could even add additional steps to the java formatting job to automatically suggest formatting changes in PRs. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Timed out. |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Mar 31, 2022
8968: Use Github Actions for unit and integration tests r=oleschoenburg a=oleschoenburg This is a refactoring and enhancement of our existing GitHub Actions workflows. With the changes here, we will have two workflows: * Tests * Code Quality They are not yet integrated with bors, meaning that they don't block merging if they fail and Jenkins is still the source of truth. ## Tests Includes the **OS support smoke tests**, **integration tests**, and **unit tests**. Tests are trigger for all pull requests and the `staging` and `trying` branches to support integration with bors in the future. Integration tests are run on a self-hosted runner. The elasticsearch exporter tests are run separately without flaky test detection on a smaller self-hosted runner. Most unit tests run in parallel on GitHub's hosted runners, except for the engine and logstream tests which are a bit too heavy and are run on a small self-hosted runner. ## Code Quality Includes **go-lint**, **CodeQL** and **java-formatting**. This PR makes no substantial changes to the go-lint and CodeQL jobs but adds another job to ensure that java code is properly formatted. In the future we could even add additional steps to the java formatting job to automatically suggest formatting changes in PRs. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
😆 Just merge :D |
|
Build failed: |
remcowesterhoud
added a commit
that referenced
this pull request
Apr 1, 2022
In #8968 we have decided to upgrade from windows-2022 to windows-latest in our smoke-tests. In this change we forgot to update the the name in bors, causing bors to get stuck waiting for a check named "Smoke tests on windows-2022" to complete.
10 tasks
19 tasks
deepthidevaki
added
the
version:8.1.0-alpha1
ChrisKujawa
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring and enhancement of our existing GitHub Actions workflows.
With the changes here, we will have two workflows:
They are not yet integrated with bors, meaning that they don't block merging if they fail and Jenkins is still the source of truth.
Tests
Includes the OS support smoke tests, integration tests, and unit tests. Tests are trigger for all pull requests and the
stagingandtryingbranches to support integration with bors in the future.Integration tests are run on a self-hosted runner. The elasticsearch exporter tests are run separately without flaky test detection on a smaller self-hosted runner.
Most unit tests run in parallel on GitHub's hosted runners, except for the engine and logstream tests which are a bit too heavy and are run on a small self-hosted runner.
Code Quality
Includes go-lint, CodeQL and java-formatting.
This PR makes no substantial changes to the go-lint and CodeQL jobs but adds another job to ensure that java code is properly formatted. In the future we could even add additional steps to the java formatting job to automatically suggest formatting changes in PRs.