Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): add start instructions to PI creation #9479

Merged
merged 1 commit into from
Jun 2, 2022
Merged

feat(gateway): add start instructions to PI creation #9479

merged 1 commit into from
Jun 2, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Jun 1, 2022

Description

Adds minimal start instructions to Gateway protocol

Related issues

closes #9396

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@pihme pihme requested a review from remcowesterhoud June 1, 2022 13:18
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Unit Test Results

   717 files  ±  0     717 suites  ±0   17m 3s ⏱️ - 2m 38s
5 406 tests  - 19  5 401 ✔️  - 19  5 💤 ±0  0 ❌ ±0 
5 570 runs   - 19  5 565 ✔️  - 19  5 💤 ±0  0 ❌ ±0 

Results for commit c2f217b. ± Comparison against base commit d8784e9.

remcowesterhoud
remcowesterhoud approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing integration test seems unrelated to this change so feel free to merge it 👍

@pihme
Copy link
Contributor Author

pihme commented Jun 2, 2022

bors merge

ghost pushed a commit that referenced this pull request Jun 2, 2022
@pihme @lenaschoenburg
merge: #9479 #9489
ecf18aa 
9479: feat(gateway): add start instructions to PI creation r=pihme a=pihme

## Description

Adds minimal start instructions to Gateway protocol

## Related issues

closes #9396 



9489: ci: check gocompat in GHA r=pihme a=oleschoenburg

Adds a step to the go-client tests that runs gocompat. 

Installation and invocation are copied from [build-go.sh](https://github.com/camunda/zeebe/blob/f831ee5cb54bc14496e19018e4dad83b64d3c9fc/.ci/scripts/distribution/build-go.sh) and [prepare-go.sh](https://github.com/camunda/zeebe/blob/cc6dcb06f7bd0eb5f0e04ee14376b7ed0dc727d4/.ci/scripts/distribution/prepare-go.sh)

Co-authored-by: pihme <pihme@users.noreply.github.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Jun 2, 2022

Build failed (retrying...):

@pihme
Copy link
Contributor Author

pihme commented Jun 2, 2022

bors retry

@ghost
Copy link

ghost commented Jun 2, 2022

Already running a review

ghost pushed a commit that referenced this pull request Jun 2, 2022
@pihme
merge: #9479
c308ab9 
9479: feat(gateway): add start instructions to PI creation r=pihme a=pihme

## Description

Adds minimal start instructions to Gateway protocol

## Related issues

closes #9396 



Co-authored-by: pihme <pihme@users.noreply.github.com>
@ghost
Copy link

ghost commented Jun 2, 2022

Build failed:

@pihme
Copy link
Contributor Author

pihme commented Jun 2, 2022

bors retry

ghost pushed a commit that referenced this pull request Jun 2, 2022
@pihme
merge: #9479
05d94e2 
9479: feat(gateway): add start instructions to PI creation r=pihme a=pihme

## Description

Adds minimal start instructions to Gateway protocol

## Related issues

closes #9396 



Co-authored-by: pihme <pihme@users.noreply.github.com>
@ghost
Copy link

ghost commented Jun 2, 2022

Build failed:

@lenaschoenburg
Copy link
Member

bors retry

ghost pushed a commit that referenced this pull request Jun 2, 2022
@pihme
merge: #9479
d312ad6 
9479: feat(gateway): add start instructions to PI creation r=pihme a=pihme

## Description

Adds minimal start instructions to Gateway protocol

## Related issues

closes #9396 



Co-authored-by: pihme <pihme@users.noreply.github.com>
@ghost
Copy link

ghost commented Jun 2, 2022

Build failed:

@pihme pihme merged commit e8643ea into main Jun 2, 2022
@pihme pihme deleted the 9396-start-instructions-in-gateway-protocol branch June 2, 2022 15:36
@ChrisKujawa ChrisKujawa added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcowesterhoud remcowesterhoud remcowesterhoud approved these changes

Assignees
No one assigned
Labels
version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend the gateway protocol to create a process instance with start instructions
4 participants
@pihme @lenaschoenburg @remcowesterhoud @ChrisKujawa