Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button missing on Results page #120

Closed
MrDeshaies opened this issue Aug 7, 2019 · 2 comments · Fixed by #136
Closed

Save button missing on Results page #120

MrDeshaies opened this issue Aug 7, 2019 · 2 comments · Fixed by #136
Assignees
Labels
enhancement New feature or request mvp Required for Minimum Viable Product
Milestone

Comments

@MrDeshaies
Copy link
Contributor

Once you "Complete" the AIA, the Results page is missing a Save button to download the json. This feature is only available as you complete the AIA, on pages 1-13.

It would be really helpful to be able to save from the Results page. Remembering to save on the last page before Completing is not very user-friendly.

Saving/Loading the JSON is useful for people to pass around the results, and will be crucial when we look at publishing the results on open.canada.ca later.

@gcharest gcharest added the enhancement New feature or request label Aug 7, 2019
@gcharest gcharest added this to the MVP 0.8 milestone Aug 7, 2019
@gcharest
Copy link
Member

gcharest commented Aug 7, 2019

Good point!

@ShadeWyrm ShadeWyrm added the mvp Required for Minimum Viable Product label Nov 4, 2019
@MrDeshaies
Copy link
Contributor Author

The save button is there and works... But this change also carried over the upload ("choose file") and start again buttons which don't work as expected.

Choose file: uploading a file updates some of the information on the results page (the green score bar), but not the results page per-se.

Start again: should go back to the start screen, but it stays on the result screen and keeps the results previously entered.

Remove the upload and restart button from the results screen if that's an easy thing? As part of #133 new download buttons may be required; could be addressed as part of that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mvp Required for Minimum Viable Product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants