Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest news beta template fails HTML validation, inconsistent with similar GCWeb patterns #49

Open
EricDunsworth opened this issue Sep 29, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@EricDunsworth
Copy link
Contributor

@fsnoddy and I noticed that the beta template in the design system's latest news page currently fails HTML validation.

The beta template is structured as a <figure> element that contains <img>, <figcaption> and <p>. But the HTML spec disallows that. The spec only allows<figcaption> to be situated at either the beginning or end of <figure>. It can't be placed in-between other elements.

There could potentially be value in revising that template to be more in line with the examples from GCWeb's context-specific features page.

PS:
The latest news page also contains other HTML validation errors.

Thanks :)!

@delisma
Copy link
Contributor

delisma commented Oct 12, 2020

@fsnoddy and I noticed that the beta template in the design system's latest news page currently fails HTML validation.

The beta template is structured as a <figure> element that contains <img>, <figcaption> and <p>. But the HTML spec disallows that. The spec only allows<figcaption> to be situated at either the beginning or end of <figure>. It can't be placed in-between other elements.

There could potentially be value in revising that template to be more in line with the examples from GCWeb's context-specific features page.

PS:
The latest news page also contains other HTML validation errors.

Thanks :)!

Please file this issue in the canada-ca/design-system-systeme-conception repo instead.

@canada-ca canada-ca locked and limited conversation to collaborators Oct 12, 2020
@delisma delisma added the bug Something isn't working label Oct 12, 2020
@DDubuc1 DDubuc1 added this to the 2nd clean up milestone Aug 15, 2022
@delisma delisma removed this from the 2nd clean up milestone Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants