Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we switch to "$defs" instead of "definitions", and all the $ref be updated accordingly, for the generated JSON Schema? #86

Open
ShahimEssaid opened this issue Aug 23, 2021 · 5 comments
Open

Can we switch to "$defs" instead of "definitions", and all the $ref be updated accordingly, for the generated JSON Schema? #86

ShahimEssaid opened this issue Aug 23, 2021 · 5 comments
Assignees
@sujaypatil96
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Improve CRDCH mod...

Comments

@ShahimEssaid
Copy link
Member

No description provided.

@ShahimEssaid ShahimEssaid added enhancement New feature or request question Further information is requested labels Aug 23, 2021
@ShahimEssaid ShahimEssaid changed the title Can we switch to "$defs" instead of "definitions", and all the $ref be updated accordingly for the generated JSON Schema? Can we switch to "$defs" instead of "definitions", and all the $ref be updated accordingly, for the generated JSON Schema? Aug 23, 2021
@gaurav gaurav mentioned this issue Aug 23, 2021
Closed
@gaurav gaurav removed the question Further information is requested label Aug 26, 2021
@gaurav
Copy link
Collaborator

gaurav commented Aug 26, 2021

Yes, we can! I've filed this issue with LinkML at linkml/linkml#305, and we'll work on this as soon as we're done with PR #75.

@gaurav gaurav added the good first issue Good for newcomers label Aug 26, 2021
@sujaypatil96 sujaypatil96 self-assigned this Aug 27, 2021
@sujaypatil96
Copy link
Contributor

Outcome of issue #305 on linkml repo should result in a change from definitions to $defs on line #4 in the ccdh data model.

@sujaypatil96
Copy link
Contributor

PR #311 which fixes this issue on the linkml repo has been merged. I think we're ready to close out this issue.

@gaurav
Copy link
Collaborator

gaurav commented Sep 13, 2021

I'll pull the latest LinkML into our fork, regenerate the artifacts, and then send them to Shahim to confirm that this is what he needs. Once he's confirmed that, we can close this issue. Thanks so much for fixing this, Sujay!

@gaurav
Copy link
Collaborator

gaurav commented Sep 14, 2021

I've updated the version of LinkML we use in PR #109. I've also added a test to make sure that the JSON Schema is valid, which unfortunately it is not (I think because of #85). I'll keep working on this until this JSON Schema can be fully validated.

@ShahimEssaid: Could you please check https://github.com/cancerDHC/ccdhmodel/pull/109/files#diff-456d10c2832bcf26f95f8adf860b978802250d5def49998ebe52b11820f65ba0 and check that this is what you needed? Please let us know if there's any other related change we need to make!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujaypatil96 sujaypatil96

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Improve CRDCH model testing (Phase 3,...
Development

No branches or pull requests
3 participants
@gaurav @ShahimEssaid @sujaypatil96