Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Linux on 2.0 version #277

Open
NogradThGin opened this issue Jun 22, 2023 · 2 comments
Open

Fixes for Linux on 2.0 version #277

NogradThGin opened this issue Jun 22, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@NogradThGin
Copy link

Hello, some errors got into the code 😋

Both on cmd.rs file.
First at line 18, there is 2 double quote a the end.
Actually: regex::Regex::new(r#"--install-directory=(.*?)""#).unwrap();
Instead of: regex::Regex::new(r#"--install-directory=(.*?)"#).unwrap();

And with ps command at line 69:
Actually: let cmd_str = r#"ps -A | grep LeagueClientUx | grep remoting-auth-token="#;
Instead of: let cmd_str = r#"ps aux | grep LeagueClientUx | grep remoting-auth-token="#;

Actually maybe ps -A is used for MacOS, I don't know.
But as far as I tested, it doesn't work on Linux.

@cangzhang
Copy link
Owner

Hi, thx for your feedback, ps -A | grep LeagueClientUx | grep remoting-auth-token= is actually for macOS.
Sorry I don't have a linux OS on my pc, since you have already there, contributions are welcome 😄

@cangzhang cangzhang added the help wanted Extra attention is needed label Jan 18, 2024
@EatedPantsu
Copy link

EatedPantsu commented Jan 21, 2024

Hello!
I'm willing to test the building and running under Linux, but I'd appreciate some help in compiling the package.

Hello, some errors got into the code

Both on cmd.rs file. First at line 18, there is 2 double quote a the end. Actually: regex::Regex::new(r#"--install-directory=(.*?)""#).unwrap(); Instead of: regex::Regex::new(r#"--install-directory=(.*?)"#).unwrap();

And with ps command at line 69: Actually: let cmd_str = r#"ps -A | grep LeagueClientUx | grep remoting-auth-token="#; Instead of: let cmd_str = r#"ps aux | grep LeagueClientUx | grep remoting-auth-token="#;

Actually maybe ps -A is used for Faggot_Os, I don't know. But as far as I tested, it doesn't work on Linux.

I've applied those changes but the build fails.

I'm using
cargo b --target "x86_64-unknown-linux-gnu"
but the app crashes after selecting sources and it does not detect league

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants