You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have many tests that assert the value of a warning message. When other can-* repos add new warnings, these tests often break. We should use a flag to only assert the value of warning messages when we're making the stache(...) call we're trying to test. We should be able to do this with a simple flag:
Another option (given by @christopherjbaker via @imaustink) is to only assert if the warning matches the expected value along with expect(...) to make sure the correct number of warnings are given like this test.
I think the best option would be a built in mechanism, something like canDev.mockWarn('expected warning') or canDev.mockWarn([ 'expected warning', 'other warning' ]). Besides simplifying the tests instead of having that code every time, it would also make future changes to this logic simpler. =]
We have many tests that assert the value of a warning message. When other
can-*
repos add new warnings, these tests often break. We should use a flag to only assert the value of warning messages when we're making thestache(...)
call we're trying to test. We should be able to do this with a simple flag:The text was updated successfully, but these errors were encountered: