Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties on a can.route.map are coerced to strings when they should not be #2277

Closed
DesignByOnyx opened this issue Feb 18, 2016 · 2 comments
Closed

Properties on a can.route.map are coerced to strings when they should not be #2277

DesignByOnyx opened this issue Feb 18, 2016 · 2 comments
Labels
bug fixed in branch
Milestone
2.3.17

Comments

@DesignByOnyx
Copy link
Contributor

I believe this issue is caused by this:

https://github.com/canjs/canjs/pull/2246/files

...and lives in isolation here:

https://jsfiddle.net/ryanwheale/0wyreatk/
@justinbmeyer
Copy link
Contributor

cc @nlundquist

@DesignByOnyx DesignByOnyx changed the title Properties on a can.Map tied to the route are errantly converted to strings Properties on a can.route.map are coerced to strings when they should not be Feb 18, 2016
@justinbmeyer justinbmeyer added this to the 2.3.17 milestone Feb 18, 2016
@justinbmeyer
Copy link
Contributor

We should only be converting the serialize-able properties.

@nlundquist nlundquist mentioned this issue Feb 18, 2016
Merged
@kylegifford kylegifford mentioned this issue May 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed in branch
Projects
None yet
Milestone
2.3.17
Development

No branches or pull requests
3 participants
@justinbmeyer @DesignByOnyx @nlundquist