You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, sanity test_rock.py files expect the image to have a specific name (name:version). This means that whenever we want to run those tests, the local docker cache should have an image with this name.
For our CI, this means that WFs must always follow this name pattern which results in a more complicated API e.g. we would not need to pass rock-name and rock-versionhere, if we didn't need to use that exact name for exporting the image to the local docker cache.
The same goes for integration environment in ROCKs repos' tox.ini files which also expect the image to have a specific name. This results in the same complications described above, but for integration-test-rock.yaml.
What needs to get done
Update test_rock.py to read the LOCAL_ROCK_IMAGE value either from args or from a local env variable. If this is not available, then fall back to the current implementation
Update integration environment in tox.ini files to do the same as well.
Not sure if we should do that (1 and 2) for one repo and tackle the rest as soon as we get to work on them or have a massive effort of updating tests in all of our ROCKs repositories
The text was updated successfully, but these errors were encountered:
Why it needs to get done
Context
At the moment, sanity test_rock.py files expect the image to have a specific name (
name:version
). This means that whenever we want to run those tests, the local docker cache should have an image with this name.For our CI, this means that WFs must always follow this name pattern which results in a more complicated API e.g. we would not need to pass
rock-name
androck-version
here, if we didn't need to use that exact name for exporting the image to the local docker cache.The same goes for integration environment in ROCKs repos'
tox.ini
files which also expect the image to have a specific name. This results in the same complications described above, but for integration-test-rock.yaml.What needs to get done
LOCAL_ROCK_IMAGE
value either from args or from a local env variable. If this is not available, then fall back to the current implementationtox.ini
files to do the same as well.When is the task considered done
test_rock.py
files are updated.tox.ini
integration environments are updated.Not sure if we should do that (1 and 2) for one repo and tackle the rest as soon as we get to work on them or have a massive effort of updating tests in all of our ROCKs repositories
The text was updated successfully, but these errors were encountered: