Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should entity have default icon? #89

Closed
barrymcgee opened this issue Mar 27, 2019 · 4 comments
Closed

Should entity have default icon? #89

barrymcgee opened this issue Mar 27, 2019 · 4 comments
Assignees
@spencerbygraves

Comments

@barrymcgee
Copy link
Contributor

If a bundle or charm does not have a default icon, should we show a default icon?

Is so, what should it be?
@barrymcgee barrymcgee mentioned this issue Mar 27, 2019
Merged
@spencerbygraves
Copy link

spencerbygraves commented Mar 27, 2019 •
edited
Loading

@barrymcgee we currently use the icon below for charm details, and we don't show icons at the top of a bundle page.

image

Is that what you mean?

@clagom
Copy link

clagom commented Mar 27, 2019

Also, for the K8s type of charms/bundles the icon would be the blue hexagon (can we provide the asset @spencerbygraves)
Screenshot 2019-03-27 at 15 02 45

@spencerbygraves
Copy link

@barrymcgee @clagom I've added the default k8s icon to the assets server - https://assets.ubuntu.com/v1/77c59327-K8s-default-charm-icon.svg

@hatched hatched mentioned this issue Mar 27, 2019
Closed
@huwshimi
Copy link
Collaborator

The icons (including the default) are returned by the charmstore. I've filed an issue there to update the k8s default: juju/charmstore#874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencerbygraves spencerbygraves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@huwshimi @barrymcgee @clagom @spencerbygraves