Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded S3 details in integration with MinIO #186

Open
misohu opened this issue Oct 20, 2023 · 0 comments
Open

Hardcoded S3 details in integration with MinIO #186

misohu opened this issue Oct 20, 2023 · 0 comments

Comments

@misohu
Copy link
Member

misohu commented Oct 20, 2023

Bug Description

To make make kserve integration with mlflow we are creating object-storage secret with annotations:

annotations:
     serving.kserve.io/s3-endpoint: "{{ s3_endpoint }}"
     serving.kserve.io/s3-usehttps: "{{ s3_usehttps }}"
     serving.kserve.io/s3-region: "{{ s3_region }}"
     serving.kserve.io/s3-useanoncredential: "{{s3_useanoncredential }}"

From these last three ones are not needed for integration with minio, but can't be committed in the secret (we will also need them in the future connecting to other object storage providers e.g. S3).

For now we keep them as constants in the src\charm.py file.

For its meaning refer to the upstream documentation .

Important finding. Kserve inference service will prefix the serving.kserve.io/s3-endpoint value with http:\\ or https:\\ based on value of serving.kserve.io/s3-usehttps.

To Reproduce

None

Environment

None

Relevant Log Output

None

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant