Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ROCK for torchserve-kfs #2

Open
kimwnasptd opened this issue Sep 5, 2023 · 1 comment
Open

Create ROCK for torchserve-kfs #2

kimwnasptd opened this issue Sep 5, 2023 · 1 comment

Comments

@kimwnasptd
Copy link
Contributor

Kubeflow is using pytorch/torchserve-kfs image, as the KServe runtime image for serving PyTorch models
https://github.com/kserve/kserve/blob/f7de5e696e8d0e64e3ed2b2493ec64244291a5c9/install/v0.11.0/kserve-runtimes.yaml#L218

The source of this image lives in https://github.com/pytorch/serve/tree/master/kubernetes/kserve and it uses the pytorch/torchserve image as base. So in order to construct the ROCK we'll need to build the base torchserve image as well.

IIUC the base pytorch/torchserve image is defined and built in https://github.com/pytorch/serve/blob/v0.8.2/docker/Dockerfile

To summarize, our ROCK will need to

cc @i-chvets @SamirPS

@kimwnasptd
Copy link
Contributor Author

Also a note regarding versioning and tagging of the upstream pytorch/torchserve-kfs image:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant