lxd: Update copy op response body when source is snapshot #14139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when copying an instance using a snapshot as the source, the response body allocated the snapshot to resources.instances and resources.containers. This is not entirely accurate, so in this commit we add a check to see if the source is a snapshot, and if so, we allocate it to resources.instances_snapshots instead of resources.instances and resources.containers. Signed-off-by: Mark Bolton <mark.bolton@canonical.com>
tomponline
approved these changes
Sep 23, 2024
mas-who
added a commit
to canonical/lxd-ui
that referenced
this pull request
Sep 24, 2024
…ration [WD-14541] (#918) ## Done - previously, an operation for creating an instance from a snapshot would include the snapshot name in the instances resource field within the operation response metadata. We had to include a workaround to filter out the snapshots in order to extract the instance name. - with this upstream [PR](canonical/lxd#14139) merged, we can now remove the workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the copy operation response body when using a snapshot as the source. Previously, the response body allocated the snapshot to
resources.instancesandresources.containers. This is not entirely accurate, so we now check to see if the source is a snapshot, and if so, we allocate it toresources.instances_snapshotsinstead ofresources.instancesandresources.containers.Closes #13999.