Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microk8s.reset --help kills your cluster #497

Closed
tbaumann opened this issue Jun 7, 2019 · 3 comments
Closed

microk8s.reset --help kills your cluster #497

tbaumann opened this issue Jun 7, 2019 · 3 comments
Labels
kind/feature New feature or request triage/good-first-issue Good for newcomers

Comments

@tbaumann
Copy link

tbaumann commented Jun 7, 2019

tilmanb@zuse:~$ microk8s.reset --help
[sudo] password for tilmanb: 
Calling clean_cluster
Cleaning resources in namespace default

I was actually fine with that. I was looking for a cleanup command.
But I called it with --help specifically because I wanted to find out what it does before I do something.

microk8s.reset should print usage info if called with parameters.

@ktsakalozos
Copy link
Member

That is a good point. Our reset wrapper https://github.com/ubuntu/microk8s/blob/master/microk8s-resources/wrappers/microk8s-reset.wrapper needs some refactoring.

@ktsakalozos ktsakalozos added kind/feature New feature or request triage/good-first-issue Good for newcomers labels Jun 10, 2019
@rzr
Copy link
Contributor

rzr commented Oct 1, 2019

Hi, I am the one to blame for --help

Expected and observed behaviour is:

$ snap info microk8s
installed:        v1.16.0             (920) 187MB classic

microk8s.reset --help
Usage: microk8s [OPTIONS...]

Options:
  -h, --help                 give this help list
  --destroy-storage          Also destroy storage

I suspect your version of k8s is oudated, please confirm version.

Maybe this change should be applied to older version too ?
#616

@ktsakalozos
Copy link
Member

The --help flag was added beginning of September so it was not released at the time this issue was opened.

I am closing this. Please feel free to reopen it if you need further improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request triage/good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants