Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wp_viewporter #2599

Closed
dos1 opened this issue Aug 30, 2022 · 3 comments
Closed

Support wp_viewporter #2599

dos1 opened this issue Aug 30, 2022 · 3 comments

Comments

@dos1
Copy link

dos1 commented Aug 30, 2022

Several clients such as SDL or Waydroid are now using viewporter protocol in order to crop and/or scale the attached buffer. It's also the recommended way for clients to deal with fractional output scaling.

Mir appears to be missing support for this protocol entirely.

Weston comes with a simple client to verify the implementation: weston-scaler.

@RAOF
Copy link
Contributor

RAOF commented Oct 5, 2022

wp_viewporter is a sensible thing to support - a lot of overlay hardware has capabilities that map very directly onto the interface exposed by wp_viewporter, so this provides optimisation opportunities that would otherwise not be available.

That you can use it to kinda implement fractional scaling is somewhat of a side effect; ideally fractional scaling would be negotiated directly, with the compositor's explicit participation, rather than worked around with a protocol that can be made to sorta get the right effect.

@Saviq Saviq unassigned RAOF and wmww Oct 5, 2022
@JamiKettunen
Copy link
Contributor

JamiKettunen commented Jan 9, 2023

Mir v2.11's missing wp_viewporter support is now visible on https://wayland.app/protocols/viewporter#compositor-support, when support is added (and new version tagged) https://github.com/vially/wayland-explorer should get a follow-up PR by running wlprobe against mir_demo_server and replacing the existing src/data/compositors/mir.json ^^

@AlanGriffiths
Copy link
Contributor

Closed by #3445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants