Fix console creation #3826
Open
Fix console creation #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3826 +/- ##
==========================================
+ Coverage 88.94% 89.04% +0.09%
==========================================
Files 256 255 -1
Lines 14584 14582 -2
==========================================
+ Hits 12972 12984 +12
+ Misses 1612 1598 -14 ☔ View full report in Codecov by Sentry. |
ricab
reviewed
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3788
Previously the test output would disappear since
StubTerminal*was being cast toWindowsTerminal*and thencin/cout/cerrwould get deleted. NowStubTerminal*is not cast at all andConsolecreation is handled by their respective Terminals.MULTI-1676