Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_secret and get_secret methods #62

Closed
carlcsaposs-canonical opened this issue May 15, 2023 · 2 comments · Fixed by #65
Closed

Add set_secret and get_secret methods #62

carlcsaposs-canonical opened this issue May 15, 2023 · 2 comments · Fixed by #65

Comments

@carlcsaposs-canonical
Copy link
Contributor

  1. we should store secrets in juju secrets if possible or in peer data if juju secrets are not available. we widely use set_secret/get_secret pattern across charms.

Originally posted by @delgod in #51 (comment)

@github-actions
Copy link
Contributor

@carlcsaposs-canonical
Copy link
Contributor Author

IMO we should wait until actual secrets implementation instead: #51 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant