Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ops.jujucontext._JujuContext #179

Closed
tonyandrewmeyer opened this issue Aug 26, 2024 · 1 comment
Closed

Use ops.jujucontext._JujuContext #179

tonyandrewmeyer opened this issue Aug 26, 2024 · 1 comment
Labels
25.04

Comments

@tonyandrewmeyer
Copy link
Collaborator

We should be able to simplify some of the code by using the new ops.jujucontext._JujuContext class to manage mocking the environment variables that normally come from Juju.

There's some compatibility code added in #178 that can be cleaned out and replaced by requiring the newer version of ops and making proper use of a _JujuContext object.

Maybe we want to do this and #125 together, or do that one first and then this one?

Relevant ops PR: canonical/operator#1313
@tonyandrewmeyer tonyandrewmeyer mentioned this issue Aug 29, 2024
Closed
@tonyandrewmeyer tonyandrewmeyer mentioned this issue Oct 10, 2024
Closed
@tonyandrewmeyer
Copy link
Collaborator Author

Moved to canonical/operator#1420

@tonyandrewmeyer tonyandrewmeyer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
25.04
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonyandrewmeyer and others