[LDAP] Comment snap service restart

Author: sinclert-canonical

src/charm.py

@@ -2090,7 +2090,11 @@ def update_config(self, is_creating_backup: bool = False) -> bool:
 
         self._handle_postgresql_restart_need()
         self._restart_metrics_service()
-        self._restart_ldap_sync_service()
+
+        # TODO: Un-comment
+        # When PostgreSQL-rock wrapping PostgreSQL-snap versions 162 / 163 gets published
+        # (i.e. snap contains https://github.com/canonical/charmed-postgresql-snap/pull/88)
+        # self._restart_ldap_sync_service()
 
         return True
 

tests/unit/test_charm.py

@@ -1711,13 +1711,13 @@ def test_update_config(harness):
         )
         _handle_postgresql_restart_need.assert_called_once()
         _restart_metrics_service.assert_called_once()
-        _restart_ldap_sync_service.assert_called_once()
+        # _restart_ldap_sync_service.assert_called_once()
         assert "tls" not in harness.get_relation_data(rel_id, harness.charm.unit.name)
 
         # Test with TLS files available.
         _handle_postgresql_restart_need.reset_mock()
         _restart_metrics_service.reset_mock()
-        _restart_ldap_sync_service.reset_mock()
+        # _restart_ldap_sync_service.reset_mock()
         harness.update_relation_data(
             rel_id, harness.charm.unit.name, {"tls": ""}
         )  # Mock some data in the relation to test that it change.
@@ -1740,7 +1740,7 @@ def test_update_config(harness):
         )
         _handle_postgresql_restart_need.assert_called_once()
         _restart_metrics_service.assert_called_once()
-        _restart_ldap_sync_service.assert_called_once()
+        # _restart_ldap_sync_service.assert_called_once()
         assert "tls" not in harness.get_relation_data(
             rel_id, harness.charm.unit.name
         )  # The "tls" flag is set in handle_postgresql_restart_need.
@@ -1751,11 +1751,11 @@ def test_update_config(harness):
         )  # Mock some data in the relation to test that it change.
         _handle_postgresql_restart_need.reset_mock()
         _restart_metrics_service.reset_mock()
-        _restart_ldap_sync_service.reset_mock()
+        # _restart_ldap_sync_service.reset_mock()
         harness.charm.update_config()
         _handle_postgresql_restart_need.assert_not_called()
         _restart_metrics_service.assert_not_called()
-        _restart_ldap_sync_service.assert_not_called()
+        # _restart_ldap_sync_service.assert_not_called()
         assert harness.get_relation_data(rel_id, harness.charm.unit.name)["tls"] == "enabled"
 
         # Test with member not started yet.
@@ -1765,7 +1765,7 @@ def test_update_config(harness):
         harness.charm.update_config()
         _handle_postgresql_restart_need.assert_not_called()
         _restart_metrics_service.assert_not_called()
-        _restart_ldap_sync_service.assert_not_called()
+        # _restart_ldap_sync_service.assert_not_called()
         assert "tls" not in harness.get_relation_data(rel_id, harness.charm.unit.name)