Check all units

Author: dragomirp

tests/integration/test_charm.py

@@ -184,24 +184,26 @@ async def test_postgresql_parameters_change(ops_test: OpsTest) -> None:
     for unit_id in UNIT_IDS:
         host = await get_unit_address(ops_test, f"{APP_NAME}/{unit_id}")
         logger.info("connecting to the database host: %s", host)
-        with psycopg2.connect(
-            f"dbname='postgres' user='operator' host='{host}' password='{password}' connect_timeout=1"
-        ) as connection, connection.cursor() as cursor:
-            settings_names = ["max_prepared_transactions", "shared_buffers", "lc_monetary"]
-            cursor.execute(
-                sql.SQL("SELECT name,setting FROM pg_settings WHERE name IN ({});").format(
-                    sql.SQL(", ").join(sql.Placeholder() * len(settings_names))
-                ),
-                settings_names,
-            )
-            records = cursor.fetchall()
-            settings = convert_records_to_dict(records)
-        connection.close()
-
-        # Validate each configuration set by Patroni on PostgreSQL.
-        assert settings["max_prepared_transactions"] == "100"
-        assert settings["shared_buffers"] == "128"
-        assert settings["lc_monetary"] == "en_GB.utf8"
+        try:
+            with psycopg2.connect(
+                f"dbname='postgres' user='operator' host='{host}' password='{password}' connect_timeout=1"
+            ) as connection, connection.cursor() as cursor:
+                settings_names = ["max_prepared_transactions", "shared_buffers", "lc_monetary"]
+                cursor.execute(
+                    sql.SQL("SELECT name,setting FROM pg_settings WHERE name IN ({});").format(
+                        sql.SQL(", ").join(sql.Placeholder() * len(settings_names))
+                    ),
+                    settings_names,
+                )
+                records = cursor.fetchall()
+                settings = convert_records_to_dict(records)
+
+                # Validate each configuration set by Patroni on PostgreSQL.
+                assert settings["max_prepared_transactions"] == "100"
+                assert settings["shared_buffers"] == "128"
+                assert settings["lc_monetary"] == "en_GB.utf8"
+        finally:
+            connection.close()
 
 
 @pytest.mark.group(1)