Skip to content

Commit b4d48b0

Browse files
committed
Merge branch 'refresh-v3' into dpe-8462-jubilant
2 parents badc7f9 + 2a806f7 commit b4d48b0

File tree

6 files changed

+4
-76
lines changed

6 files changed

+4
-76
lines changed

.github/workflows/release.yaml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,9 @@ on:
1616
- '.github/workflows/sync_docs.yaml'
1717

1818
jobs:
19-
tag:
20-
name: Create charm refresh compatibility version git tag
21-
uses: canonical/data-platform-workflows/.github/workflows/tag_charm_edge.yaml@v35.0.2
22-
with:
23-
track: '16'
24-
permissions:
25-
contents: write # Needed to create git tag
2619

2720
ci-tests:
2821
name: Tests
29-
needs:
30-
- tag
3122
uses: ./.github/workflows/ci.yaml
3223
secrets: inherit
3324
permissions:
@@ -36,11 +27,10 @@ jobs:
3627
release:
3728
name: Release charm
3829
needs:
39-
- tag
4030
- ci-tests
4131
uses: canonical/data-platform-workflows/.github/workflows/release_charm_edge.yaml@v35.0.2
4232
with:
43-
track: ${{ needs.tag.outputs.track }}
33+
track: '16'
4434
artifact-prefix: ${{ needs.ci-tests.outputs.artifact-prefix }}
4535
secrets:
4636
charmhub-token: ${{ secrets.CHARMHUB_TOKEN }}

charmcraft.yaml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -84,19 +84,6 @@ parts:
8484
files:
8585
plugin: dump
8686
source: .
87-
after:
88-
- poetry-deps # Ensure poetry is installed
89-
build-packages:
90-
- git
91-
override-build: |
92-
# Set `charm_version` in refresh_versions.toml from git tag
93-
# Create venv in `..` so that git working tree is not dirty
94-
python3 -m venv ../refresh-version-venv
95-
source ../refresh-version-venv/bin/activate
96-
poetry install --only build-refresh-version
97-
write-charm-version
98-
99-
craftctl default
10087
stage:
10188
- LICENSE
10289
- refresh_versions.toml

poetry.lock

Lines changed: 2 additions & 45 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,6 @@ jubilant = "^1.5.0"
7676
tomli-w = "^1.2.0"
7777
tomli = "^2.3.0"
7878

79-
[tool.poetry.group.build-refresh-version]
80-
optional = true
81-
82-
[tool.poetry.group.build-refresh-version.dependencies]
83-
charm-refresh-build-version = "^0.4.0"
84-
8579
[build-system]
8680
requires = ["poetry-core>=1.0.0"]
8781
build-backend = "poetry.core.masonry.api"

refresh_versions.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# https://canonical-charm-refresh.readthedocs-hosted.com/latest/refresh-versions-toml/
22

3+
charm = "16/1.0.0"
34
charm_major = 1
45
workload = "16.10"

src/charm.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,6 @@ def __init__(self, *args):
333333
self.refresh is not None
334334
and self.refresh.workload_allowed_to_start
335335
and not self.refresh.next_unit_allowed_to_refresh
336-
and int(self.unit.name.split("/")[1]) >= self.refresh._get_partition()
337336
):
338337
if self.refresh.in_progress:
339338
self.reconcile()

0 commit comments

Comments
 (0)