-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider WAR builds #481
Comments
Hi @aindlq, I've considered some kind of WAR wrapper. Really what's missing is an artifact repo. I've only used Maven Central a little bit for one other project and I'm still unfamiliar/uncomfortable with it. It was a real bear to set up, and then it broke when I tried to push another version and I don't remember what I had to do to fix it. (So I guess it could be argued that what's missing is not an artifact repo but rather a competent developer 😄) I've also looked into GitHub Packages. This seemed really nice, but it doesn't currently support public packages. AWS CodeArtifact could be another option. Some kind of artifact repo is going to be needed soon for other reasons, so this is going to have to get solved one way or another. |
In my opinion you need to bite the bullet and publish to Maven Central. Especially taking into account recent events with JCenter/Bintray (https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/). So many projects had to migrate to Maven Central. But as a result now there should be a good amount of up-to-date knowledge on how to do that, e.g https://getstream.io/blog/publishing-libraries-to-mavencentral-2021/ or https://dzone.com/articles/how-to-publish-artifacts-to-maven-central Let me know if I can help in any way. |
Hi @dianat , this is a low/zero priority for me for the foreseeable future. |
While updating to 5.0 I've just stumbled on the fact that there is no WAR builds anymore (#339), I wonder if you are open to reconsider this change but maybe with slightly different approach?
As I can see the main issue was because you had jar and war all in one bundle, so that is why all these hackery in the pom file was necessary, but what if one have separate builds (sub projects) for JAR and WAR build. E.g as it is done for blazegraph, there is a sub-project for standalone jar - https://github.com/blazegraph/database/tree/master/blazegraph-jar and a sub-project for war - https://github.com/blazegraph/database/tree/master/bigdata-war
We are trying to use cantaloupe in https://github.com/researchspace/researchspace, and with 4.* the WAR build was extremely convenient. We are using Gradle with Gretty plugin (https://gretty-gradle-plugin.github.io/gretty-doc/index.html) for the build, and it has a nice feature where one can just start multiple webapps in one go in dev environment (https://gretty-gradle-plugin.github.io/gretty-doc/Farm-web-app-list.html#_repository_based_web_app_references) and then even generate runnable zip bundle out of it (https://gretty-gradle-plugin.github.io/gretty-doc/Product-generation.html).
Obviously we can hack something in a fork for our use case, but I wonder if there is a possibility to have a kind of official WAR builds.
Also have you considered pushing cantaloupe builds to maven central?
The text was updated successfully, but these errors were encountered: