You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I checked NaN values in the calculations and couldn't find any NaN value, and also verified that PartialOrd::partial_cmp at the end never falls to unwrap_or fallback. I suspect this is due to sort implementations in stdlib detecting incorrect Ord implementations and panicking in that case starting with Rust 1.81.
The text was updated successfully, but these errors were encountered:
Time to time the search functionality (both triggered by
ctrl + r
ormcfly search
) crashes with:The panic comes from this part of the code: https://github.com/cantino/mcfly/blob/master/src/history/history.rs#L408-L449.
This is the stacktrace:
And I was also able to get values that cause the crash, see this Rust playground: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c6dae2dc0d0e3d2788cd870c19c42ee7
I checked NaN values in the calculations and couldn't find any NaN value, and also verified that
PartialOrd::partial_cmp
at the end never falls tounwrap_or
fallback. I suspect this is due to sort implementations in stdlib detecting incorrectOrd
implementations and panicking in that case starting with Rust 1.81.The text was updated successfully, but these errors were encountered: