Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cds build now generates the correct output folder structure for Node.js and Java apps. #353

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

LotharBender
Copy link
Contributor

@LotharBender LotharBender commented Nov 21, 2023

  • identical output folder structure for node.js and java as documented in Capire
  • use existing package.json from db folder instead of generated one

@LotharBender LotharBender changed the title build correctly creates output folder structure fix: build correctly creates output folder structure Nov 21, 2023
@LotharBender LotharBender changed the title fix: build correctly creates output folder structure fix: build creates correct folder structure for Java and Node.js apps Nov 22, 2023
@LotharBender LotharBender changed the title fix: build creates correct folder structure for Java and Node.js apps fix: build creates correct output folder structure Nov 22, 2023
@LotharBender
Copy link
Contributor Author

LotharBender commented Nov 22, 2023

We should add some tests for the cds build plugin functionality - currently it isn't tested at all...

@johannes-vogel johannes-vogel changed the title fix: build creates correct output folder structure fix: cds build now generates the correct output folder structure for Node.js and Java apps. Nov 22, 2023
@johannes-vogel
Copy link
Contributor

We should add some tests for the cds build plugin functionality - currently it isn't tested at all...

@swaldmann @LotharBender @patricebender

I'd propose to add tests after we've released that hotfix or is that something you can do quivkly within that PR?
I'd like to ship the fix asap.

Copy link
Member

@patricebender patricebender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me if we add the test later (as soon as possible) if you are certain that this change is correct.

@LotharBender
Copy link
Contributor Author

LotharBender commented Nov 22, 2023

fine by me if we add the test later (as soon as possible) if you are certain that this change is correct.

Deployment layout is now generated according to Capire doc.

project
  - gen
    - pg
      package.json
      - db 
        csn.json
        - data
  • Java
    For Java there is currently only a Liquibase, but no cds deployer based sample app.
project
  - gen
    - pg
      package.json
      - db 
        csn.json
        - data

@johannes-vogel
Copy link
Contributor

@swaldmann could you please also have a look?

@johannes-vogel
Copy link
Contributor

@LotharBender The changes in cap-js/postgres are independent of Java. Hence, I think we can merge and release, don't we?

@LotharBender
Copy link
Contributor Author

LotharBender commented Nov 24, 2023

@LotharBender The changes in cap-js/postgres are independent of Java. Hence, I think we can merge and release, don't we?

Yesterday we had a meeting with @mofterdinger and agreed to go for the same deployment folder structure for Java and Node.js as described in Capire - let's merge this PR.

@LotharBender LotharBender merged commit 875aca4 into main Nov 24, 2023
5 checks passed
@LotharBender LotharBender deleted the fix/postgresBuildOutput branch November 24, 2023 09:11
@cap-bots cap-bots mentioned this pull request Nov 24, 2023
@cap-bots cap-bots mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants