-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cds build
now generates the correct output folder structure for Node.js and Java apps.
#353
Conversation
LotharBender
commented
Nov 21, 2023
•
edited
Loading
edited
- identical output folder structure for node.js and java as documented in Capire
- use existing package.json from db folder instead of generated one
2bc9d24
to
3c2c30c
Compare
We should add some tests for the cds build plugin functionality - currently it isn't tested at all... |
cds build
now generates the correct output folder structure for Node.js and Java apps.
@swaldmann @LotharBender @patricebender I'd propose to add tests after we've released that hotfix or is that something you can do quivkly within that PR? |
c43cb06
to
f595510
Compare
f595510
to
207b656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me if we add the test later (as soon as possible) if you are certain that this change is correct.
Deployment layout is now generated according to Capire doc.
|
@swaldmann could you please also have a look? |
@LotharBender The changes in cap-js/postgres are independent of Java. Hence, I think we can merge and release, don't we? |
Yesterday we had a meeting with @mofterdinger and agreed to go for the same deployment folder structure for Java and Node.js as described in Capire - let's merge this PR. |