fix(localized): refs in subqueries in from are translated
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated if the main queries target is `localized` and this is not overwritten by `cds.localized: false`, `ref`erences in subqueries will also be translated. This was already the case for subqueries in columns or expands. The responsible code has been moved to a central entry point for all subqueries, hence this now also covers subqueries in `from`.
patricebender
requested review from
danjoa,
johannes-vogel and
stewsk
as code owners
johannes-vogel
approved these changes
Dec 1, 2023
Merged
Merged
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the main queries target is
localizedand this is not overwritten bycds.localized: false,references in subqueries will also be translated. This was already the case for subqueries in columns or expands. The responsible code has been moved to the central entry point for all subqueries, hence this now also covers subqueries infrom.