Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retain Error object for unique constraint violation #446

Merged
merged 14 commits into from
Feb 16, 2024

Conversation

BobdenOs
Copy link
Contributor

@BobdenOs BobdenOs commented Feb 7, 2024

No description provided.

Copy link
Member

@patricebender patricebender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test :)

@johannes-vogel johannes-vogel enabled auto-merge (squash) February 12, 2024 14:31
@johannes-vogel
Copy link
Contributor

@BobdenOs I think we need to apply the same logic in hana service as well.

@BobdenOs BobdenOs changed the title fix(sqlite): Retain Error object for unique constraint violation fix: Retain Error object for unique constraint violation Feb 16, 2024
@johannes-vogel johannes-vogel merged commit d27ee79 into main Feb 16, 2024
4 checks passed
@johannes-vogel johannes-vogel deleted the BobdenOs-patch-1 branch February 16, 2024 13:59
@cap-bots cap-bots mentioned this pull request Feb 16, 2024
johannes-vogel pushed a commit that referenced this pull request Feb 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.6.2</summary>

##
[1.6.2](db-service-v1.6.1...db-service-v1.6.2)
(2024-02-16)


### Fixed

* ** `infer`:** unique alias for scoped subqueries
([#465](#465))
([5dbaa8e](5dbaa8e))
* Allow only for array of arrays as data for plain SQL
([#449](#449))
([22e1c43](22e1c43))
* dont insert structured elements
([#461](#461))
([f3f688d](f3f688d))
* ignore virtual keys in
UPSERT([#463](#463))
([49adbf3](49adbf3))
* INSERT entries containing undefined values
([#453](#453))
([d3aad75](d3aad75))
* select without columns from unknown entity
([#466](#466))
([eb857de](eb857de))
</details>

<details><summary>sqlite: 1.5.1</summary>

##
[1.5.1](sqlite-v1.5.0...sqlite-v1.5.1)
(2024-02-16)


### Fixed

* **`sqlite`:** Retain Error object for unique constraint violation
([#446](#446))
([d27ee79](d27ee79))
</details>

<details><summary>postgres: 1.5.1</summary>

##
[1.5.1](postgres-v1.5.0...postgres-v1.5.1)
(2024-02-16)


### Fixed

* **`sqlite`:** Retain Error object for unique constraint violation
([#446](#446))
([d27ee79](d27ee79))
</details>

<details><summary>hana: 0.0.5</summary>

##
[0.0.5](hana-v0.0.4...hana-v0.0.5)
(2024-02-16)


### Fixed

* **`sqlite`:** Retain Error object for unique constraint violation
([#446](#446))
([d27ee79](d27ee79))
* **hana:** ensure the database connection does not enable auto commit
([#448](#448))
([b2ca1da](b2ca1da))
* **hana:** Ensure xpr with logical operator to only contain comparisons
([#452](#452))
([a2ecb22](a2ecb22))
* ignore virtual keys in
UPSERT([#463](#463))
([49adbf3](49adbf3))
* select without columns from unknown entity
([#466](#466))
([eb857de](eb857de))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@cap-bots cap-bots mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants