fix: optimize foreign key access in a join relevant path #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk and
BobdenOs
as code owners
especially for paths of length > 2 fix #479
BobdenOs
approved these changes
Feb 28, 2024
| @@ -2080,6 +2076,31 @@ module.exports = Object.assign(cqn4sql, { | |||
| notSupportedOps, | |||
| }) | |||
|
|
|||
| function calculateElementName(token) { | |||
| const nonJoinRelevantAssoc = [...token.$refLinks].findIndex(l => l.definition.isAssociation && l.onlyForeignKeyAccess) | |||
| let name | |||
There was a problem hiding this comment.
Looks like some left over, but should work.
Merged
johannes-vogel
pushed a commit
that referenced
this pull request
Feb 28, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.6.4</summary> ## [1.6.4](db-service-v1.6.3...db-service-v1.6.4) (2024-02-28) ### Fixed * **`cqn2sql`:** smart quoting also for update statements ([#475](#475)) ([1688f77](1688f77)) * `INSERT` with first `undefined` value ([#484](#484)) ([c21e3c4](c21e3c4)) * Allow SELECT.join queries again with full infer call ([#469](#469)) ([5329ec0](5329ec0)) * optimize foreign key access in a join relevant path ([#481](#481)) ([5e30de4](5e30de4)), closes [#479](#479) </details> <details><summary>hana: 0.0.6</summary> ## [0.0.6](hana-v0.0.5...hana-v0.0.6) (2024-02-28) ### Added * cds.Vector support for the HANAService ([#442](#442)) ([1057a13](1057a13)) ### Fixed * `TypeError` for `cds bind` in MTX scenario ([#482](#482)) ([38722fe](38722fe)) * Allow SELECT.join queries again with full infer call ([#469](#469)) ([5329ec0](5329ec0)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
stewsk
reviewed
Feb 29, 2024
There was a problem hiding this comment.
you could maybe add
// test that no optimization is done if a filter is applied
SELECT from ClassRoomPupil {
classroom[name = 'Firenze'].ID
}
// test what happens if both an optimizable and a non-optimizable path are present
SELECT from ClassRoomPupil {
classroom.ID,
classroom.name
}
// variation of previous test
SELECT from ClassRoomPupil {
classroom.ID,
classroom[name = 'Firenze'].ID as ID2
}
patricebender
added a commit
that referenced
this pull request
Feb 29, 2024
follow up to review comment: #481 (review)
patricebender
added a commit
that referenced
this pull request
Feb 29, 2024
follow up to review comment: #481 (review)
Merged
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the path resolves to a foreign key, we should not create a join for the last association, instead we shortcut to the foreign key. This was not considered for join relevant paths.
fix #479