fix: Reduce insert queries for deep update #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel,
stewsk and
patricebender
as code owners
BobdenOs
commented
Apr 9, 2024
patricebender
approved these changes
Apr 9, 2024
db-service/test/deep/deep.test.js
Outdated
| @@ -770,7 +770,7 @@ describe('test deep query generation', () => { | |||
| }) | |||
|
|
|||
| describe('INSERT', () => { | |||
| test('creates sub inserts', () => { | |||
| test.skip('creates sub inserts', () => { | |||
There was a problem hiding this comment.
shouldn't we adapt the test expectation?
Merged
johannes-vogel
added a commit
that referenced
this pull request
Apr 12, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.8.0</summary> ## [1.8.0](db-service-v1.7.0...db-service-v1.8.0) (2024-04-12) ### Added * Odata built-in query functions ([#558](#558)) ([6e63367](6e63367)) * support HANA stored procedures ([#542](#542)) ([52a00a0](52a00a0)) ### Fixed * **`expand`:** Only accept on structures, assocs or table aliases ([#551](#551)) ([3248512](3248512)) * **`order by`:** for localized sorting, prepend table alias ([#546](#546)) ([a273a92](a273a92)) * etag with stream_compat ([#562](#562)) ([b0a3a41](b0a3a41)) * exclude `cds.LargeBinary` from wildcard expansion ([#577](#577)) ([6661d63](6661d63)) * Reduce insert queries for deep update ([#568](#568)) ([55e5114](55e5114)) * Reduced count query complexity when possible ([#553](#553)) ([3331f02](3331f02)) </details> <details><summary>postgres: 1.7.0</summary> ## [1.7.0](postgres-v1.6.0...postgres-v1.7.0) (2024-04-12) ### Added * Odata built-in query functions ([#558](#558)) ([6e63367](6e63367)) </details> <details><summary>hana: 0.2.0</summary> ## [0.2.0](hana-v0.1.0...hana-v0.2.0) (2024-04-12) ### Added * Odata built-in query functions ([#558](#558)) ([6e63367](6e63367)) * support HANA stored procedures ([#542](#542)) ([52a00a0](52a00a0)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com>
Merged
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.