fix(expand): enable expanding from subquery
#709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we `select from <subquery>` we do not have a `SELECT.from.ref` but the `<subquery>` has a `.target` because it has been inferred properly. Use the name of the `.target` for building the correlated subquery, instead of dumping. fix #708
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs and
sjvans
as code owners
stewsk
approved these changes
Jun 25, 2024
Merged
patricebender
pushed a commit
that referenced
this pull request
Jun 25, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.10.2</summary> ## [1.10.2](db-service-v1.10.1...db-service-v1.10.2) (2024-06-25) ### Fixed * **`expand`:** enable expanding from subquery ([#709](#709)) ([5ed03e5](5ed03e5)), closes [#708](#708) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we
select from <subquery>we do not have aSELECT.from.refbut the<subquery>has a.targetbecause it has been inferred properly.Use the name of the
.targetfor building the correlated subquery, instead of dumping.fix #708