fix: for aggregated expand always set explicit alias
#739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to have the proper result structure, we need to rename
foreign key references in the inner `expand` subquery
to match the element name of the target.
instead of `author { <outer>.author_ID }` it needs to be
`author { <outer>.author_ID as ID` to match the expected result
structure.
for #708
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs and
sjvans
as code owners
patricebender
changed the title
expand + group by use pk name instead of fk nameexpand always set explicit alias
johannes-vogel
approved these changes
Jul 11, 2024
BobdenOs
reviewed
Jul 12, 2024
Merged
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to have the proper result structure, we need to rename foreign key references in the inner
expandsubquery to match the element name of the target.instead of
author { <outer>.author_ID }it needs to beauthor { <outer>.author_ID as IDto match the expected result structure.for #708