Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: build script generates cds8 dependency in deployer app #758

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

patricebender
Copy link
Member

@patricebender patricebender commented Jul 24, 2024

this should not impact the dependencies of the actual node project, hence this is not a breaking change

@patricebender patricebender changed the title deps: build script generates cds8 dependency deps!: build script generates cds8 dependency Jul 24, 2024
@patricebender patricebender changed the title deps!: build script generates cds8 dependency deps: build script generates cds8 dependency Jul 24, 2024
@patricebender patricebender changed the title deps: build script generates cds8 dependency deps: build script generates cds8 dependency in deployer app Jul 24, 2024
@johannes-vogel
Copy link
Contributor

@BobdenOs it seems there's a race condition with your previous PR, can you please check?

@johannes-vogel johannes-vogel merged commit 5c21a67 into main Jul 25, 2024
4 checks passed
@johannes-vogel johannes-vogel deleted the patricebender-patch-1 branch July 25, 2024 09:29
@cap-bots cap-bots mentioned this pull request Jul 25, 2024
patricebender pushed a commit that referenced this pull request Jul 25, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.12.0</summary>

##
[1.12.0](db-service-v1.11.0...db-service-v1.12.0)
(2024-07-25)

### Fixed

* see changelog

### Changed

* generic-pool as real dep
([#750](#750))
([b50c907](b50c907))

### Performance Improvements

* HANA list placeholder
([#380](#380))
([3eadfea](3eadfea))
</details>

<details><summary>postgres: 1.9.2</summary>

##
[1.9.2](postgres-v1.9.1...postgres-v1.9.2)
(2024-07-25)


### Changed

* build script generates cds8 dependency in deployer app
([#758](#758))
([5c21a67](5c21a67))
</details>

<details><summary>hana: 1.1.1</summary>

##
[1.1.1](hana-v1.1.0...hana-v1.1.1)
(2024-07-25)


### Fixed

* assocs with default value
([#752](#752))
([a8660cf](a8660cf))
* make name for columns for ordinality unique
([#746](#746))
([d3f9b23](d3f9b23))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Johannes Vogel <johannes.vogel@sap.com>
@cap-bots cap-bots mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants