fix: pseudo paths in expands #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudo paths were leading to a dump if they were used in an expand on an association which follows them in its filter expression. We need to revisit #617, as there is a lot of duplicate logic in two main functions of `infer` --> get rid of `attachRefLinksToArg`!
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs,
sjvans and
David-Kunz
as code owners
stewsk
approved these changes
Nov 18, 2024
Merged
patricebender
pushed a commit
that referenced
this pull request
Nov 19, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.15.1</summary> ## [1.15.1](db-service-v1.15.0...db-service-v1.15.1) (2024-11-18) ### Fixed * cross joins without on-condition ([#899](#899)) ([c61a04a](c61a04a)) * pseudo paths in expands ([#896](#896)) ([014c50c](014c50c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pseudo paths were leading to a dump if they were
used in an expand on an association which follows them in its filter expression.
We need to revisit #617, as there is a lot of duplicate logic in two main functions of
infer--> get rid ofattachRefLinksToArg!