Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SAP HANA functions should also be callable in upper case on SAP HANA #910

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

johannes-vogel
Copy link
Contributor

According to https://cap.cloud.sap/docs/guides/databases#functions-mappings-for-runtime-queries

For the SAP HANA functions, both usages are allowed: all-lowercase as given above, as well as all-uppercase.

test/cds.js Outdated Show resolved Hide resolved
@johannes-vogel johannes-vogel added the next release pr to be checked for next release label Nov 22, 2024
@johannes-vogel johannes-vogel merged commit 50ebd10 into main Nov 25, 2024
3 checks passed
@johannes-vogel johannes-vogel deleted the hana-functions branch November 25, 2024 11:20
@cap-bots cap-bots mentioned this pull request Nov 22, 2024
johannes-vogel added a commit that referenced this pull request Nov 25, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.16.0</summary>

##
[1.16.0](db-service-v1.15.1...db-service-v1.16.0)
(2024-11-25)


### Changed

* single column in `search` function is also treated as CQN `list`
([#898](#898))
([f6593e6](f6593e6))


### Fixed

* foreignKeys aspect on association may not be set
([#903](#903))
([732a2f3](732a2f3))
* insert on uuid with default value
([#911](#911))
([545e489](545e489))
* `session_context`, `current_date`, `current_time` and
`current_timestamp` are treated as SAP HANA functions and are callable
in upper case ([#910](#910))
([50ebd10](50ebd10))
* wrap values in array if it is object, so it can be spreaded
([#882](#882))
([11f3e8b](11f3e8b))
</details>

<details><summary>hana: 1.5.0</summary>

##
[1.5.0](hana-v1.4.1...hana-v1.5.0)
(2024-11-25)


### Added

* config options for fuzzy search
([#898](#898))
([f6593e6](f6593e6))
* support current_utctimestamp
([#865](#865))
([aaf39ad](aaf39ad))


### Fixed

* `current_date`, `current_time`, `current_timestamp` and
`current_utctimestamp` are SAP HANA functions and are callable in upper
case ([#910](#910))
([50ebd10](50ebd10))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Johannes Vogel <johannes.vogel@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release pr to be checked for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants