fix: quoted mode #937
Merged
fix: quoted mode #937
+20
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-vogel
requested review from
danjoa,
stewsk,
BobdenOs,
patricebender,
sjvans and
David-Kunz
as code owners
BobdenOs
reviewed
Dec 10, 2024
db-service/lib/cqn2sql.js
Outdated
| this.class.prototype.name = (name) => name.id || name | ||
| this.class.prototype.name = (name) => { | ||
| let e = name.id || name | ||
| const pn = this.model?.definitions[e]?.['@cds.persistence.name'] |
There was a problem hiding this comment.
I don't like the model lookup. It might be a bigger refactor, but passing the target from the outside would make this much more reliable.
There was a problem hiding this comment.
I tried to solve "quoted mode" at a single point.
Why do you think that it's more reliable once passed from the outside?
BobdenOs
approved these changes
Dec 12, 2024
Merged
johannes-vogel
added a commit
that referenced
this pull request
Dec 17, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.16.1</summary> ## [1.16.1](db-service-v1.16.0...db-service-v1.16.1) (2024-12-16) ### Fixed * handle undefined DEBUG ([#942](#942)) ([dd2da3a](dd2da3a)), closes [#941](#941) * only expand partial foreign key if explicitly requested ([#916](#916)) ([96911ad](96911ad)) * quoted mode ([#937](#937)) ([9e62b22](9e62b22)) * sort property is case insensitive ([#924](#924)) ([2c72c87](2c72c87)) * wildcard expand with aggregation ([#923](#923)) ([bbe7be0](bbe7be0)) </details> <details><summary>sqlite: 1.7.8</summary> ## [1.7.8](sqlite-v1.7.7...sqlite-v1.7.8) (2024-12-16) ### Fixed * default `[development]` URL to `:memory:` ([#926](#926)) ([51e8aa7](51e8aa7)) </details> <details><summary>postgres: 1.10.5</summary> ## [1.10.5](postgres-v1.10.4...postgres-v1.10.5) (2024-12-16) ### Fixed * sort property is case insensitive ([#924](#924)) ([2c72c87](2c72c87)) </details> <details><summary>hana: 1.5.1</summary> ## [1.5.1](hana-v1.5.0...hana-v1.5.1) (2024-12-16) ### Fixed * deep groupby ([#919](#919)) ([ce24264](ce24264)) * expressions with not on HANA ([#925](#925)) ([e67a31b](e67a31b)) * quoted mode ([#937](#937)) ([9e62b22](9e62b22)) * sort property is case insensitive ([#924](#924)) ([2c72c87](2c72c87)) * track expression type through expressions ([#950](#950)) ([a083f74](a083f74)) ### Performance Improvements * Remove `$$RN$$` and additional sub selects ([#929](#929)) ([b3743a1](b3743a1)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com>
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.