Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: starts endswith for null values #975

Merged
merged 11 commits into from
Jan 15, 2025
Merged

fix: starts endswith for null values #975

merged 11 commits into from
Jan 15, 2025

Conversation

larslutz96
Copy link
Contributor

@larslutz96 larslutz96 commented Jan 9, 2025 •
edited
Loading

Wrap startswith and endswith with coalesce to return false when element is NULL.

@larslutz96 larslutz96 changed the title fix functions always return true or false fix: functions always return true or false Jan 9, 2025
@larslutz96 larslutz96 marked this pull request as ready for review January 10, 2025 09:02
@larslutz96 larslutz96 changed the title fix: functions always return true or false fix: starts endswith for null values Jan 10, 2025
patricebender
patricebender reviewed Jan 10, 2025
View reviewed changes
db-service/lib/cql-functions.js
@@ -75,15 +75,15 @@ const StandardFunctions = {
* @param {string} y
* @returns {string}
*/
startswith: (x, y) => `instr(${x},${y}) = 1`, // sqlite instr is 1 indexed
startswith: (x, y) => `coalesce(instr(${x},${y}) = 1,false)`, // sqlite instr is 1 indexed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this covers only SQLite, is this also relevant for other dbs?:)

Copy link
Contributor Author

@larslutz96 larslutz96 Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added same for postgres. Not relevant for hana

David-Kunz
David-Kunz approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@David-Kunz David-Kunz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@patricebender patricebender enabled auto-merge (squash) January 15, 2025 11:09
@patricebender patricebender merged commit f0330bc into main Jan 15, 2025
3 checks passed
@patricebender patricebender deleted the fix-functions-always-return-true-false branch January 15, 2025 12:11
@cap-bots cap-bots mentioned this pull request Jan 15, 2025
Merged
johannes-vogel added a commit that referenced this pull request Jan 28, 2025
@cap-bots @johannes-vogel
chore: release main (#961)
0b1b533 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.17.0</summary>

##
[1.17.0](db-service-v1.16.2...db-service-v1.17.0)
(2025-01-27)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* **`UPDATE`:** no assocs in list which matches subquery results
([4bcb88a](4bcb88a))
* **`UPDATE`:** only perform subselect matching if necessary
([#989](#989))
([4bcb88a](4bcb88a))
* contains not evaluting to bool
([#980](#980))
([760484b](760484b))
* nested ternary in calculated element
([#981](#981))
([5f4a1fe](5f4a1fe))
* reject virtual elements in all expressions
([#972](#972))
([d0c949d](d0c949d))
* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
* use "$$value$$" as internal column name for UPSERT
([#976](#976))
([8c86b86](8c86b86))
</details>

<details><summary>sqlite: 1.8.0</summary>

##
[1.8.0](sqlite-v1.7.8...sqlite-v1.8.0)
(2025-01-27)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))
</details>

<details><summary>postgres: 1.11.0</summary>

##
[1.11.0](postgres-v1.10.5...postgres-v1.11.0)
(2025-01-27)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
</details>

<details><summary>hana: 1.6.0</summary>

##
[1.6.0](hana-v1.5.2...hana-v1.6.0)
(2025-01-27)


### Added

* support driver self-wrapping (for Dynatrace)
([#974](#974))
([5346bc4](5346bc4))
* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* Fix expand aliasing
([#959](#959))
([f39097c](f39097c))
* groupby path expression with overlapping identifier
([#992](#992))
([b579da8](b579da8))
* multi raw SQL queries
([#973](#973))
([b953480](b953480))
* Remove `orderBy` ref check for `sql_simple_queries`
([#964](#964))
([1b77725](1b77725))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Johannes Vogel <johannes.vogel@sap.com>
This was referenced Jan 28, 2025
Closed
Merged
johannes-vogel added a commit that referenced this pull request Jan 28, 2025
@cap-bots @johannes-vogel
chore: release main (#999)
c8284d1 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.17.0</summary>

##
[1.17.0](db-service-v1.16.2...db-service-v1.17.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* **`UPDATE`:** no assocs in list which matches subquery results
([4bcb88a](4bcb88a))
* **`UPDATE`:** only perform subselect matching if necessary
([#989](#989))
([4bcb88a](4bcb88a))
* contains not evaluting to bool
([#980](#980))
([760484b](760484b))
* nested ternary in calculated element
([#981](#981))
([5f4a1fe](5f4a1fe))
* reject virtual elements in all expressions
([#972](#972))
([d0c949d](d0c949d))
* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
* use "$$value$$" as internal column name for UPSERT
([#976](#976))
([8c86b86](8c86b86))
</details>

<details><summary>sqlite: 1.8.0</summary>

##
[1.8.0](sqlite-v1.7.8...sqlite-v1.8.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))
</details>

<details><summary>postgres: 1.11.0</summary>

##
[1.11.0](postgres-v1.10.5...postgres-v1.11.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
</details>

<details><summary>hana: 1.6.0</summary>

##
[1.6.0](hana-v1.5.2...hana-v1.6.0)
(2025-01-28)


### Added

* support driver self-wrapping (for Dynatrace)
([#974](#974))
([5346bc4](5346bc4))
* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* Fix expand aliasing
([#959](#959))
([f39097c](f39097c))
* groupby path expression with overlapping identifier
([#992](#992))
([b579da8](b579da8))
* multi raw SQL queries
([#973](#973))
([b953480](b953480))
* Remove `orderBy` ref check for `sql_simple_queries`
([#964](#964))
([1b77725](1b77725))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Johannes Vogel <johannes.vogel@sap.com>
This was referenced Jan 28, 2025
Closed
Merged
johannes-vogel added a commit that referenced this pull request Jan 28, 2025
@cap-bots @johannes-vogel
chore: release main (#1001)
6c4b539 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.17.0</summary>

##
[1.17.0](db-service-v1.16.2...db-service-v1.17.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* **`UPDATE`:** no assocs in list which matches subquery results
([4bcb88a](4bcb88a))
* **`UPDATE`:** only perform subselect matching if necessary
([#989](#989))
([4bcb88a](4bcb88a))
* contains not evaluting to bool
([#980](#980))
([760484b](760484b))
* nested ternary in calculated element
([#981](#981))
([5f4a1fe](5f4a1fe))
* reject virtual elements in all expressions
([#972](#972))
([d0c949d](d0c949d))
* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
* use "$$value$$" as internal column name for UPSERT
([#976](#976))
([8c86b86](8c86b86))
</details>

<details><summary>sqlite: 1.8.0</summary>

##
[1.8.0](sqlite-v1.7.8...sqlite-v1.8.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))
</details>

<details><summary>postgres: 1.11.0</summary>

##
[1.11.0](postgres-v1.10.5...postgres-v1.11.0)
(2025-01-28)


### Added

* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* starts endswith for null values
([#975](#975))
([f0330bc](f0330bc))
</details>

<details><summary>hana: 1.6.0</summary>

##
[1.6.0](hana-v1.5.2...hana-v1.6.0)
(2025-01-28)


### Added

* support driver self-wrapping (for Dynatrace)
([#974](#974))
([5346bc4](5346bc4))
* support for cds.Map
([#889](#889))
([cde7514](cde7514))


### Fixed

* Fix expand aliasing
([#959](#959))
([f39097c](f39097c))
* groupby path expression with overlapping identifier
([#992](#992))
([b579da8](b579da8))
* multi raw SQL queries
([#973](#973))
([b953480](b953480))
* Remove `orderBy` ref check for `sql_simple_queries`
([#964](#964))
([1b77725](1b77725))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Johannes Vogel <johannes.vogel@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricebender patricebender patricebender approved these changes

@David-Kunz David-Kunz David-Kunz approved these changes

@danjoa danjoa Awaiting requested review from danjoa danjoa is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@stewsk stewsk Awaiting requested review from stewsk stewsk is a code owner

@BobdenOs BobdenOs Awaiting requested review from BobdenOs BobdenOs is a code owner

@sjvans sjvans Awaiting requested review from sjvans sjvans is a code owner

@gregorwolf gregorwolf Awaiting requested review from gregorwolf gregorwolf is a code owner

@sebastianesch sebastianesch Awaiting requested review from sebastianesch sebastianesch is a code owner

@vobu vobu Awaiting requested review from vobu vobu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larslutz96 @David-Kunz @patricebender