fix: optimize foreign key access for expand with aggregations #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is another follow up for #708 -> if the expand column was a foreign key access, the column was not properly re-written which resulted in the reported error. we now make use of the common functionality which ensure proper column re-write. Along the way, support for structured columns was added as well.
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs and
sjvans
as code owners
BobdenOs
approved these changes
Jul 8, 2024
yeah true the function should ideally have a parameter which makes it possible to omit aliases. |
will do this separately |
Merged
johannes-vogel
added a commit
that referenced
this pull request
Jul 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.11.0</summary> ## [1.11.0](db-service-v1.10.3...db-service-v1.11.0) (2024-07-08) ### Added * **search:** enable deep search with path expressions ([#590](#590)) ([e9e9461](e9e9461)) ### Changed * `search` interprets only first search term instead of raising an error ([#707](#707)) ([0b9108c](0b9108c)) ### Fixed * optimize foreign key access for expand with aggregations ([#734](#734)) ([77b7978](77b7978)) </details> <details><summary>hana: 1.1.0</summary> ## [1.1.0](hana-v1.0.1...hana-v1.1.0) (2024-07-08) ### Added * Enable native HANA fuzzy search for `search` function queries ([#707](#707)) ([0b9108c](0b9108c)) ### Fixed * **mtx:** sidecar scenario due to usage of wrong credentials ([#732](#732)) ([0b5c91f](0b5c91f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is another follow up for #708
-> if the expand column was a foreign key access, the column was not properly re-written which resulted in the reported error.
we now make use of the common functionality which ensure proper column re-write. Along the way, support for structured columns was added as well.