Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting of Decimal Fields as Integer in Change Log Table #137

Open
rahul03kumar opened this issue Nov 20, 2024 · 3 comments
Open

Formatting of Decimal Fields as Integer in Change Log Table #137

rahul03kumar opened this issue Nov 20, 2024 · 3 comments
Assignees

Comments

@rahul03kumar
Copy link

Hello Team,

We have noticed an issue in the Change log: sometimes, an edm:decimal attribute is rendered as an integer. Kindly check if we can have a feature if rendering happens considering decimal precision.

Thanks & Regards,
Rahul

image

@nkaputnik
Copy link
Contributor

Hello @rahul03kumar
this is an issue we've also encountered ourselves. This is due to the new DB drivers used in CDS 8.
We are looking into this,

Best,
Nick

@rahul03kumar
Copy link
Author

Hello @nkaputnik,

thanks for update.

@nkaputnik
Copy link
Contributor

Hello @rahul03kumar
javascript has no native support for Decimal, it rather operates on Numbers, so it seems that the formatting of the numbers to the target format happens at a different point in time with the new DB driver (in the DB itself, rather than upfront in the DB driver), so the req.diff function we use now doesn't know anything about it anymore.
Changing this in our plugin will be quite complex to solve, but we have an idea that maybe we could use calculated expressions for Fiori Elements annotations. We need to check this with the experts, and it also only has a low probability to work, but it would be a straigthforward solution, if it works.

Best,
Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants