-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement gRPC delegation in Local Hub #645
Labels
Milestone
Comments
mszostok
added
area/engine
Relates to Engine
area/hub
Relates to Hub
enhancement
New feature or request
labels
Feb 24, 2022
5 tasks
This was referenced Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
After Investigate existing solutions to speed up Local Hub rewrite task, we decided to give up with Local Hub rewrite. Instead, we will implement our delegated storage in separate Go service and use gRPC in Local Hub to delegate
values
resolution.The initial protobufs were defined in #644
Steps
createTypeInstance
mutation to use thecreateTypeInstances
. If not possible, remove it and adjust all its usage.capact/hub-js/graphql/local/schema.graphql
Lines 386 to 401 in f6f487e
value
only for built-in storage backendsAdditional
Update Local Hub GraphQL mutations and queries with
backend.context
property. It should be of typeAny!
. For example:Validate Storage TypeInstance value - Stretch, if not possible, extract to dedicated task. - extracted to: Add Storage TypeInstance related validation #656
Integration tests are out of scope
Related issues
See epic #604 for reason and use cases.
The text was updated successfully, but these errors were encountered: