Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add App Review plugin #324

Merged
merged 7 commits into from
Nov 19, 2024
Merged

feat: add App Review plugin #324

merged 7 commits into from
Nov 19, 2024

Conversation

robingenz
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #320

@robingenz robingenz added the feature Feature request label Nov 15, 2024
@robingenz robingenz self-assigned this Nov 15, 2024
@robingenz
Copy link
Member Author

@mertyldrr This is the boilerplate code for #320. Please create a PR with the actual implementation based on this branch (feat/issue-320). Let me know if you have any questions or if i can help you in any way! 🙌

Please try to use the following type definition:

export interface AppReviewPlugin {
  /**
   * Open the App Store page for the current app and, if possible, open the dialog to leave a review.
   * 
   * Only available on Android and iOS.
   * 
   * @since 6.0.0
   */
	openAppStore(): Promise<void>;
  /**
   * Request an in-app review.
   * 
   * Only available on Android and iOS.
   * 
   * @since 6.0.0
   */
	requestReview(): Promise<void>;
}

You may need to add options to the methods.

Copy link

pkg-pr-new bot commented Nov 15, 2024

Open in Stackblitz

@capawesome-team/capacitor-android-battery-optimization

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-android-battery-optimization@324

@capawesome/capacitor-android-dark-mode-support

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-android-dark-mode-support@324

@capawesome-team/capacitor-android-foreground-service

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-android-foreground-service@324

@capawesome/capacitor-app-review

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-review@324

@capawesome/capacitor-app-update

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-update@324

@capawesome/capacitor-background-task

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-background-task@324

@capawesome/capacitor-badge

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-badge@324

@capawesome/capacitor-cloudinary

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-cloudinary@324

@capawesome-team/capacitor-datetime-picker

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-datetime-picker@324

@capawesome-team/capacitor-file-opener

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-file-opener@324

@capawesome/capacitor-file-picker

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-file-picker@324

@capawesome/capacitor-live-update

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-live-update@324

@capawesome/capacitor-managed-configurations

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-managed-configurations@324

@capawesome/capacitor-photo-editor

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-photo-editor@324

@capawesome/capacitor-posthog

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-posthog@324

@capawesome/capacitor-screen-orientation

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-screen-orientation@324

@capawesome/capacitor-torch

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-torch@324

commit: c6892f0

@mertyldrr
Copy link
Contributor

@robingenz thank you 🙌

mertyldrr and others added 3 commits November 18, 2024 19:02
* feat(app-review): add definitions.ts

* feat(app-review): android implementation

* feat(app-review): ios implementation

* feat(app-review): run build

* add changeset

* implement feedback from review
@robingenz robingenz marked this pull request as ready for review November 19, 2024 06:45
@robingenz robingenz merged commit 51a1b2b into main Nov 19, 2024
2 checks passed
@robingenz robingenz deleted the feat/issue-320 branch November 19, 2024 06:50
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add app-review plugin
2 participants