Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blueprint structs #8

Open
encukou opened this issue Oct 9, 2023 · 0 comments
Open

Blueprint structs #8

encukou opened this issue Oct 9, 2023 · 0 comments
Labels
guideline To be included in guidelines PEP

Comments

@encukou
Copy link
Contributor

encukou commented Oct 9, 2023 •
edited
Loading

Our current PyModuleDef, PyType_Spec, PyConfig are OK, but need tweaks:

  • be versioned (either put a version number in the struct, or version the functions that use the struct)
  • be read only once by the VM -- any information should be copied out; the VM should never use the struct after the function that uses it returns
  • be extensible -- the current "slots" concept works but the slots need to be:
    • strongly typed
    • able to be marked optional (if the current VM doesn't understand the slot ID, it's ignored)

All other structs should be opaque. (Py_buffer is an exception...)
@encukou encukou mentioned this issue Oct 10, 2023
Open
@encukou encukou added guideline To be included in guidelines PEP and removed guideline To be included in guidelines PEP labels Oct 11, 2023
@encukou encukou mentioned this issue Oct 12, 2023
Open
@encukou encukou added the guideline To be included in guidelines PEP label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
guideline To be included in guidelines PEP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@encukou