Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: menu-complete is adding description to completion #2247

Closed
2 of 11 tasks
Mikilio opened this issue Feb 16, 2024 · 2 comments · Fixed by carapace-sh/carapace#993
Closed
2 of 11 tasks

bash: menu-complete is adding description to completion #2247

Mikilio opened this issue Feb 16, 2024 · 2 comments · Fixed by carapace-sh/carapace#993
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Mikilio
Copy link

Mikilio commented Feb 16, 2024

Current Behavior

If I type git commi and use my shortcut for menu-complete, it completes properly the first time. But when repeatedly using it to cycle through the options, it adds the descriptions as well.

Expected Behavior

When cycling using menu-complete or menu-complete-backward it should complete using only the completion not the description.

Steps To Reproduce

  1. configure readline (.inputrc) to have a button activating menu-complete, eg. ("\C-i": menu-complete)
  2. use it to complete git commi

Version

0.30.1

OS

  • Linux
  • OSX
  • Windows

Shell

  • Bash
  • Elvish
  • Fish
  • Nushell
  • Oil
  • Powershell
  • Xonsh
  • Zsh

Anything else?

No response

@Mikilio Mikilio added the bug Something isn't working label Feb 16, 2024
@rsteube
Copy link
Member

rsteube commented Feb 16, 2024

Urgs - I was hoping no one is using the weird stuff.
Can be done, but I need a way to detect if current mode is complete or menu-complete.

@rsteube rsteube added the help wanted Extra attention is needed label Feb 16, 2024
@Mikilio
Copy link
Author

Mikilio commented Feb 17, 2024

Stackoverflow had something promising.

Apparently COMP_TYPE is set differently depending on the operation used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants