Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing for loading translation strings #3077

Conversation

klaascuvelier
Copy link
Contributor

Closes #3032

The current implementation of the TranslationStrings type does not correctly allow for nesting.
This change will fix that.

Changelog

Changed

  • fix TranslationStrings typing

@klaascuvelier klaascuvelier requested a review from a team as a code owner November 28, 2024 14:08
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 5d5fee3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/6760c841d57fd70008f8463f
😎 Deploy Preview https://deploy-preview-3077--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akshat55 Akshat55 changed the title fix 3032: typing for translation strings fix: typing for translation strings Dec 17, 2024
@Akshat55 Akshat55 changed the title fix: typing for translation strings fix: typing for loading translation strings Dec 17, 2024
@Akshat55 Akshat55 merged commit f591581 into carbon-design-system:master Dec 17, 2024
14 checks passed
Copy link

🎉 This PR is included in version 5.56.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect typedefinition for TranslationStrings (fix suggested)
2 participants