feat: convert components to use OnPush change detection strategy #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>
Signed-off-by: rrothschild18 <raultonello18@gmail.com>
Signed-off-by: rrothschild18 <raultonello18@gmail.com>
Signed-off-by: rrothschild18 <raultonello18@gmail.com>
Signed-off-by: rrothschild18 <raultonello18@gmail.com>
Signed-off-by: rrothschild18 <raultonello18@gmail.com>
…#3066 Signed-off-by: rrothschild18 <raultonello18@gmail.com>
Signed-off-by: rrothschild18 <raultonello18@gmail.com>
…system#3066 Signed-off-by: rrothschild18 <raultonello18@gmail.com>
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-angular-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update components to use On Push, part of issue-3066
Changelog
Changed
Select + fix unit tests
Loader
Progress
Number input + fix unit tests
While migrating components to use OnPush change detection, some unit tests started failing. The issue was that the fixture wasn't updating to new input values even when using
fixture.detectChanges().My research revealed that Angular v14 introduced a new API for setting input properties for
fixture.componentRef:setInput(commit) that seems to work as before.However, using
fixture.componentRef.setInput(propertyName, value)didn't resolve all test failures. I had to manually trigger change detection in those cases.If my approach is incorrect, please let me know the best way to handle these unit testing scenarios.