We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change
e.preventDefault() is called during a keyup event:
e.preventDefault()
keyup
carbon-components-svelte/src/Toggle/Toggle.svelte
Lines 67 to 72 in c1c8309
This prevents the change event from dispatching that otherwise should. Is this intentional?
Demo: https://stackblitz.com/edit/sveltejs-kit-template-default-ewqjmk?file=src%2Froutes%2F%2Bpage.svelte (inspired by #1609)
on:change
I think it would be fair to forward on:keydown without handling it. The HTML <input type="checkbox"> will fire change on click and SPACE, not ENTER.
on:keydown
<input type="checkbox">
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Issue
e.preventDefault()
is called during akeyup
event:carbon-components-svelte/src/Toggle/Toggle.svelte
Lines 67 to 72 in c1c8309
This prevents the
change
event from dispatching that otherwise should. Is this intentional?Reproduction
Demo: https://stackblitz.com/edit/sveltejs-kit-template-default-ewqjmk?file=src%2Froutes%2F%2Bpage.svelte (inspired by #1609)
on:change
handleron:change
handlerProposal
I think it would be fair to forward
on:keydown
without handling it. The HTML<input type="checkbox">
will firechange
on click and SPACE, not ENTER.The text was updated successfully, but these errors were encountered: