feat(pagination-nav): add tooltipPosition prop
#1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theetrain
reviewed
May 18, 2023
theetrain
reviewed
May 21, 2023
There was a problem hiding this comment.
@SimpleProgrammingAU I'd say this is good to go, depending on how you feel about this one prop definition change.
@metonym though the React component doesn't offer control over the PaginationNav's tooltip positioning, nor do the docs have strict guidelines on tooltip positioning, I feel this enhancement is good. The inside and outside options are interesting, and I suppose they can be included as well.
Outside example:
Inside example:
|
@theetrain Makes sense to me! @SimpleProgrammingAU Thank you for working on this 🙏 |
metonym
changed the title
tooltipPosition prop
Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>
|
Agree with documentation change; added commit. Should be ready for merge (?) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following options for
tooltipPositionfor thepaginationNavcomponent as requested in #1656:"left""right""top""bottom""outside""inside"Close #1656
This is my first pull request for this project. Lemme know if I've messed anything up 👍