Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header hamburger button should be optional #434

Closed
brunnerh opened this issue Nov 29, 2020 · 1 comment
Closed

Header hamburger button should be optional #434

brunnerh opened this issue Nov 29, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@brunnerh
Copy link
Contributor

Currently it always shows the button on small displays, even if there is no side nav. From the documentation:

Hamburger menu: The hamburger icon is used to open product navigation such as the left panel. The hamburger menu is only needed when there is a collapsable left navigation.

The example given on that page also has no side menu.

Since the navigation component is specified outside the header, it might be necessary to add a separate property or make isSideNavOpen have three meaningful states and use that to hide the button (it could accept null or undefined for example, maybe should be the default then).

@jquesada2016
Copy link

I 100% agree with this observation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants