Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightbox media viewer] Layout updates #6328

Closed
kirbyevans opened this issue Jun 9, 2021 · 1 comment
Closed

[Lightbox media viewer] Layout updates #6328

kirbyevans opened this issue Jun 9, 2021 · 1 comment
Labels
adopter: AEM used when component or pattern will be used by this adopter adopter support epic Feature request A new adopter requested feature priority: medium

Comments

@kirbyevans
Copy link

kirbyevans commented Jun 9, 2021

The problem

There are inconsistencies between the current implementation of the Lightbox media viewer and its design specs. There are issues with the margin/padding and the image scrolling with the supporting image copy.

The solution

We hope by simplifying the layout within the Lightbox media viewer that these issues will be resolved. Attached are the updated design specs for the Lightbox media viewer. These specs should address alignment of the image and supporting copy, as well as, how to accommodate supporting copy when it isn't able to fit within the Lightbox media viewer's visible area.

Additional information

Design specs for the proposed solution can be found here:

PDF
Sketch file

Preview of specs for Lightbox media viewer

image
image

@shixiedesign
Copy link
Contributor

To be turned into Epic: design spec done. Need func spec, dev issue, QA issues. We need 1 website issue for all the lightbox changes coming from AEM (6328, 6329, 6314)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: AEM used when component or pattern will be used by this adopter adopter support epic Feature request A new adopter requested feature priority: medium
Projects
None yet
Development

No branches or pull requests

8 participants